Menu
▾
▴
RE: [ACPI] Fix for OmniBooks in main code?
|
From: Moore, R. <rob...@in...> - 2002-05-07 15:14:46
|
See the latest version of the code in the 20020503 patch. In this version,
the X_ fields of the FADT are treated as optional even if the table revision
indicates a 2.0 table. Further, the fields are optional on a per-field
basis. This should address the OmniBook issue.
If it still does not work, we would like to understand why not.
Bob
-----Original Message-----
From: Stefan Bellon [mailto:sb...@sb...]
Sent: Monday, May 06, 2002 4:27 PM
To: acp...@li...
Subject: [ACPI] Fix for OmniBooks in main code?
Hi!
Is there any chance that the patch suggested by Bryan Mawhinney a few
weeks ago to support OmniBooks may be included into the main ACPI patch?
----8<----------8<----------8<----------8<----------8<----------8<----
--- drivers/acpi/tables/tbconvrt.c.old Mon Apr 15 16:27:47 2002
+++ drivers/acpi/tables/tbconvrt.c Mon Apr 15 16:37:25 2002
@@ -190,8 +190,11 @@
/*
* The ACPI FADT revision number is FADT2_REVISION_ID=3
* So, if the current table revision is less than 3 it is type 1.0
+ * However, type 2.0 tables that don't contain Xfirmware_ctrl and
+ * other 64 bit pointers are also treated as type 1.0
*/
- if (acpi_gbl_FADT->header.revision >= FADT2_REVISION_ID) {
+ if (acpi_gbl_FADT->header.revision >= FADT2_REVISION_ID
+ && ((fadt_descriptor_rev2*) acpi_gbl_FADT)->Xfirmware_ctrl)
{
/* We have an ACPI 2.0 FADT but we must copy it to our local
buffer */
*FADT2 = *((fadt_descriptor_rev2*) acpi_gbl_FADT);
----8<----------8<----------8<----------8<----------8<----------8<----
Thanks a lot.
Greetings,
Stefan.
--
Stefan Bellon * <mailto:sb...@sb...> * <http://www.sbellon.de/>
PGP 2 and OpenPGP keys available from my home page
100% of people born in 1839, who ate carrots, are dead.
_______________________________________________________________
Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: ban...@so...
_______________________________________________
Acpi-devel mailing list
Acp...@li...
https://lists.sourceforge.net/lists/listinfo/acpi-devel
|