[ACPI] Re: [PATCH 3/6]init call cleanup

[Rolf E. B. <eik...@sf...>]

Li Shaohua wrote:
> Trival patch for CPU hotplug. In CPU identify  part, only did cleaup for
> intel CPUs. Need do for other CPUs if they support S3 SMP.
>
> @@ -405,7 +405,7 @@ void __init init_bsp_APIC(void)
>  	apic_write_around(APIC_LVT1, value);
>  }
>
> -void __init setup_local_APIC (void)
> +void __devinit setup_local_APIC (void)
                                  ^

>  {
>  	unsigned long oldvalue, value, ver, maxlvt;
>

Please remove this space while you are at it.

> @@ -556,7 +556,7 @@ void __init early_cpu_init(void)
>   * and IDT. We reload them nevertheless, this function acts as a
>   * 'CPU state barrier', nothing should get across.
>   */
> -void __init cpu_init (void)
> +void __devinit cpu_init (void)
>  {
>  	int cpu = smp_processor_id();
>  	struct tss_struct * t = &per_cpu(init_tss, cpu);

This one too.

Eike