[ACPI] Re: [PATCH 0/3]making ACPICA safe for suspend/resume - take 2

[Li S. <sha...@in...>]

On Thu, 2005-01-27 at 16:03, Pavel Machek wrote:
> > > why can't be the same done in code that calls
> > > device's suspend() method from PCI code? That would be smaller change,
> > > and we would not duplicate a lot of code.
> > This is good for pci_disable_device (suspend), but not for resume. We
> > must restore PCI config and then call pci_enable_device.
> 
> Ok, perhaps we need pci_resume_device() wrapper, then, which does
> pci_restore_config() now, but we can easily add pci_enable_device()
> there?
I agree. It's better all such things are doing on PCI core. Every device
driver just is doing the similar. Then we need a mechanism to know if a
device is really enabled (maybe check dev->driver) or it's a bus master.

Thanks,
Shaohua