From: Li, S. <sha...@in...> - 2004-08-03 01:13:15
|
I don't think your patch works, and even it works for your system, it will break other systems. The goal of 'setonboot' is to prevent setting LINK device's IRQ every time, which we added last year. Without it, many systems will break. IIRC, its goal is to resolve a bug in bugzilla. But currently I don't remember the exact bug number. Thanks, Shaohua >-----Original Message----- >From: Nathan Bryant [mailto:nb...@op...] >Sent: Monday, August 02, 2004 10:18 PM >To: Li, Shaohua >Cc: ste...@gm...; acp...@li... >Subject: Re: [ACPI] "irq 11: nobody cared" after S3 > >Li, Shaohua wrote: >> I guess the bug is: ACPI sets LNKE's IRQ from 10 to 11 in boot time. >> LNKE's register is at LPC bridge offset 0x68, but current PCI config >> space save/restore code only handles first 0x40 bytes. After resume, >> LNKE's register doesn't recover. So LNKE will actually route to 10, but >> ACPI still thinks it routes to 11. Then you will get such error. I guess >> such error is unavoidable unless LPC bridge driver exists (it can >> save/restore all affected config space instead of first 0x40 bytes). > >Hi, > >I agree with you, but I suspect a better fix is something like the >attached diff, from my local tree. (My machine has similar problems, but >this is not tested yet. Will test tonight and then send a patch to Len >if it works out.) |