Re: [ACPI] [PATCH] ACPI poweroff fixes for 2.4.26-pre2

[M. B. <ser...@ne...>]

Sorry about that patch this really doesn't make sence,

in kernels 2.4.x now in drives/acpi/Config.in

if [ "$CONFIG_ACPI" =3D "y" ]; then
ACPI_SLEEP =3D y

if acpi support (CONFIG_ACPI) is equal to no =3D>
the drives/acpi/system.c is not compiled at all.

the only thing just don't make sense (for me) is permission to compile
ACPI without CONFIG_PM ?

in conclusion without any patch acpi_system_save_state never is "return
ok", so you can ignore my patch.

and arch/i386/config.in shouldn't be like this:

if [ "$CONFIG_PM" =3D "y" ]; then
source drivers/acpi/Config.in
fi

thanks=20
I will investe more ...

On Fri, 2004-03-26 at 01:01, S=E9rgio Monteiro Basto wrote:
> Preamble :
> I can be confused, but far as I know, you propose a patch for a _very
> wrong_ thing, ( I believe that you are right ).
> acpi_system_save_state is one reality, at least in kernel 2.4.26-pre2,
> but what you propose looks like, that just resolve half of the problem.
> if it a recently patch that made this problem I don't know.
>=20
> Seeing the code yes, you are right.
> I don't know if as make any sense to you but, what do you think put
> acpi_system_save_state under #ifdef CONFIG_PM instead of CONFIG_SLEEP ?
> like this=20
>=20
> thanks
> On Thu, 2004-03-25 at 23:00, Pavel Machek wrote:
> > Hi!
> >=20
> > > so acpi_system_save_state(state) does do nothing at all ?
> > > or does return nothing at all ?
> >=20
> > IIRC there was patch that made acpi_system_save_state() do nothing at
> > all if !CONFIG_ACPI_SLEEP. I'm arguing thats very wrong.
> > 								Pavel
--=20
S=E9rgio M. B.