Re: [Abook-devel] abook 0.6.0pre2

[<mic...@ea...>]

Le 7 sept. 2006 à 16:27, Jaakko Heinonen a écrit :

>
> 0.6.0pre2:
> 	http://abook.sourceforge.net/devel/abook-0.6.0pre2.tar.gz
> 	http://abook.sourceforge.net/devel/abook-0.6.0pre2.tar.gz.asc


I've noticed some problems with this pre-release - it may be just on  
my side, but who knows:


A - Comma is transformed in underscore in address field and in  
database when using abookrc sample file

Steps to reproduce:

1 - Copy sample.abookrc in home/.abook

2 - Enter in the address: 8, rue de la Mer

3 - Observe the result in the view

This is when the abookrc.sample is used.



B - The bscal function changes the anniversary field only in the  
view, not in the database, when sample abookrc file is used.

Steps to reproduce:

0 - Copy sample.abookrc in home/.abook

1 - Enter as anniversary
day: 15
month: 11
year: 1951

2 - Observe the output in the view: 1951-11-15

3 - Export as bsdcal

4 - Observe the result in bsdcal file: 11/15 Anniversary of ...

5 - Return to the anniversary field and observe the view: 1951


C - The anniversay field, which is noted as standard field in man  
page is not loaded at launch time when not using abookrc sample file

Indeed in view.c, 	around line 140:

		{ N_("OTHER"), { NICK, URL, NOTES, -1 } },

Should not it be:

		{ N_("OTHER"), { NICK, URL, NOTES, ANNIVERSARY, -1 } },



D - The bscal function changes the anniversary field only in the  
view, not in the database.

When the patch in C is applied, a similar change to the one noted in  
B occurs in the Anniversary field, but this time the field becomes  
empty.


F - There is a discrepancy between the abookrc.5 man page and the  
sample.abookrc

That's not critical, but it makes the reading a bit confusing.

In the explaination of set index.format;

1 - In sample.abookrc

# The below example displays:
#  * the content of the 'name' field (with a maximum of 22 characters)
#  * the first of the 'phone', 'workphone' or 'mobile' fields
#    happening not to be empty (right aligned within 12 characters)
#  * the 'anniversary' field, with no length limit
set index_format=" {name:25} {phone:-12|workphone|mobile} {anniversary}"

Note that in the second line, 22 is the number of characters, in the  
last line 25.

2 - In abookrc.5 man page

              {name:22}
                      displays  the  name  field  with  a  maximal   
width of 22
                      characters.

               {phone:-13|workphone|mobile}
                      displays (right aligned within a width of 13  
characters),
                      either  the  phone,  workphone or mobile field,  
whichever
                      being the first to be non-empty.

               Default is " {name:22} {email:40} {phone:12|workphone| 
mobile}"

Note 13 characters in phone: explaination, but 12 in Default.



E - A minor esthetic problem in help

I've just noticed that there is one tabulation too many in the   
message of line 20 in help.h, it makes the explaination shift from  
the other ones.

So, I've corrected the fr.po file, but it affects all the po file and  
obviously the help.c file.


Here's the new fr.po file (some corrections and new translations).






Cheers,
Michèle
<http://micmacfr.homeunix.org>