Re: [A-A-P-develop] Regression when building static libraries with MSVC

[Bram M. <Br...@mo...>]

Thore Karlsen wrote:

> I just upgraded from 1.74 to 1.77, and my build broke. The problem seems
> to be that in msvc.py, these lines:
> 
>     scope["BUILDLIB_ACTION"] = "build_msvc_lib"
>     scope["BUILDDLL_ACTION"] = "build_msvc_dll"
> 
> Have been replaced with these lines:
> 
>     scope["C_BUILDLIB_ACTION"] = "build_msvc_lib"
>     scope["C_BUILDDLL_ACTION"] = "build_msvc_dll"
>     scope["CXX_BUILDLIB_ACTION"] = "build_msvc_lib"
>     scope["CXX_BUILDDLL_ACTION"] = "build_msvc_dll"
> 
> I'm not sure why these lines were added, but now when I have a :lib
> command, my source files are compiled to object files instead of
> libobject files, and the link fails.
> 
> I tried searching through the AAP source for CXX_BUILDLIB_ACTION and
> C_BUILDLIB_ACTION, but I didn't see those variables reference anywhere.

BUILDLIB_ACTION and CXX_BUILDDLL_ACTION are referenced in the
default.aap recipe.  I can't find the others either.  It's possible that
names are concatenated somewhere. CXX_BUILDDLL_ACTION only appears to be
used for non-MS-Windows systems.

> If I put the file back to the way it was, everything builds fine.

This was changed half a year ago.  I can't remember why this was changed
or who suggested it...

Safest would be to add the old lines back.  I don't think that the new
lines would cause a problem and there probably was a reason why they
were added.

-- 
hundred-and-one symptoms of being an internet addict:
50. The last girl you picked up was only a jpeg.

 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
///        Sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\              Project leader for A-A-P -- http://www.A-A-P.org        ///
 \\\     Buy LOTR 3 and help AIDS victims -- http://ICCF.nl/lotr.html   ///