User Activity

  • Posted a comment on merge request #113 on Distributed Proofreaders

    Yes, I was just now thinking of something similar to that. For example, I might have my browser set to request en_GB and fr_CA. DP has neither, but I would prefer that it choose some form of English over any form of French. Possibly, for displaying the site when using the browser preference the rule needs to be: (a) Use the primary language code to determine whether we have any locales that provide that language. Thus, if the user requested en_GB and fr we would first look to see if we have any "en"...

  • Posted a comment on merge request #113 on Distributed Proofreaders

    For [d986f4]: (1) The comments you're adding say "This holds true for some common cases (it -> it_IT, br -> br_BR) but fails at one of the most common (en -> en_US, en_CA, en_GB, ?)." I wonder what that reference to br -> br_BR is intended to represent. BR as a locale is Brazil, I believe. br as a language code is for Breton. Brazil, of course, uses Portuguese, with a locale of pt_BR. Were you perhaps intending pt -> pt_PT? (2) Not specifically about the change you're implementing in this fix, but...

  • Modified a comment on merge request #96 on Distributed Proofreaders

    Looks good, but I'm a bit confused by what seems to be an extraneous line in [639c0a], tools/site_admin/sitenews.php We seem to be replacing 1 mysql_query with 2 identical mysqli_query calls. - $result = mysql_query("DELETE FROM news_items WHERE id=$item_id"); + $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id"); + $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id");

  • Modified a comment on merge request #96 on Distributed Proofreaders

    Looks good, but I'm a bit confused by what seems to be an extraneous line in [639c0a], tools/site_admin/sitenews.php We seem to be replacing 1 mysql_query with 2 identical mysqli_query calls. ```- $result = mysql_query("DELETE FROM news_items WHERE id=$item_id"); $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id"); $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id");```

  • Modified a comment on merge request #96 on Distributed Proofreaders

    Looks good, but I'm a bit confused by what seems to be an extraneous line in [639c0a], tools/site_admin/sitenews.php We seem to be replacing 1 mysql_query with 2 identical mysqli_query calls. - $result = mysql_query("DELETE FROM news_items WHERE id=$item_id"); + $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id"); + + $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id");

  • Modified a comment on merge request #96 on Distributed Proofreaders

    Looks good, but I'm a bit confused by what seems to be an extraneous line in [639c0a], tools/site_admin/sitenews.php We seem to be replacing 1 mysql_query with 2 identical mysqli_query calls. - $result = mysql_query("DELETE FROM news_items WHERE id=$item_id"); + $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id"); + $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id");

  • Posted a comment on merge request #96 on Distributed Proofreaders

    Looks good, but I'm a bit confused by seems to be an extraneous line in [639c0a], tools/site_admin/sitenews.php We seem to be replacing 1 mysql_query with 2 identical mysqli_query calls. ```@@ -116,29 +116,30 @@ case 'delete': // Delete a specific site news item $result = mysql_query("DELETE FROM news_items WHERE id=$item_id"); $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items WHERE id=$item_id"); $result = mysqli_query(DPDatabase::get_connection(), "DELETE FROM news_items...

  • Posted a comment on merge request #96 on Distributed Proofreaders

    OK; I've never been sure exactly what will trigger a merge conflict, and what wo...

View All

Personal Data

Username:
wf49670
Joined:
2013-04-13 18:06:00

Projects

  • No projects to display.

Skills

  • No skills entered.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks