Wesley

Yes, feel free to include me in the CONTRIBUTORS file if the patch checks out. That would be great! Hopefully it will help others. It's always frustrating when api changes in dependencies break previously functional packages and libraries. All the best, -Dr. Wesley Botello-Smith On Tue, Jul 30, 2019 at 5:06 PM jdurrant jdurrant@users.sourceforge.net wrote: Hi Wesley. Just wanted to let you know that I got your code. Much thanks for this contribution! I've gotten this version running on Python 3 as...

Hi, I tried sending the code you, but I got a reply that the message was not delivered: Delivery has failed to these recipients or groups: Your message wasn't delivered due to a permission or security issue. It may have been rejected by a moderator, the address may only accept email from certain senders, or another restriction may be preventing delivery. i am going to attache the code here. I have just tested it on a new iMac workstation working with a fresh install of conda (4.6.14, via anaconda),...

SUCCESS! After the above bug fixes, wisp.py is now sufficiently compatible with networkx >= 2.0 such that it can successfully run the 'simple-example' that comes with the installation. Can anyone point me to who to contact to construct a patch / update / bug fix/ etc?

After the above fix, another quirk of newer networkx versions was found. Line 766: temp[0]=temp[0]+G.edge[temp[-2]][temp[-1]]['weight'] needs to be changed to temp[0]=temp[0]+G.edges[temp[-2],temp[-1]]['weight'] in order to accomadate the new syntax for edge (or edges in v>2.0) access

The above fix seems to just open up a related problem... it seems that previous versions of networkx use 'list' objects as return values for the 'neighbors' function, but newer versions use 'dictionary-keyiterator' objects. So the solution is to wrap the result being fed into 'node_neighbors' in 'list()' e.g. line 761 node_neighbors=G.neighbors(paths_growing_out_from_source[i][-1]) becomes node_neighbors=list(G.neighbors(paths_growing_out_from_source[i][-1]))

It seems that the error is again do to a different signature. Some searching reveals that this was written for networkx versions below 2.0. New versions of networkx (2.0 and up) have had several major changes, such as the signature of the 'Graph' constructor. There are 2 uses of this constructor in 'wisp.py' line 1216 and line 1001 in both cases, 'Graph(data=' needs to be replaced with 'Graph(incoming_graph_data=' when using networkx >= 2.0 Fixing these issues leads to a new bug, however: On line...

The bug fix seems to work and the shortest path is computed, however, a new error is coming up after 'Starting serial portion of path-finding algorithm': # Calculating paths... # Calculating the shortest path between any of the specified sources and any of the specified sinks... # The shortest path has length 1.136358953726239 # Identifying the cutoff required to produce 15 paths... # Testing the cutoff 1.136358953726239... # Starting serial portion of path-finding algorithm (will run for 5.0 seconds)......

I think I may have tracked part of the error. It looks like wisp.py is using G=networkx.Graph(data=correlation_matrix However, under networkx 2.2, the signature for networkx.Graph is: 'networkx.Graph(self, incoming_graph_data=None, **attr)' rather than 'networkx.Graph(self,data=None, **attr)' as it is in some versions... I am checking to see if updating this line will fix the bug