Vivien Delmon

Fix compilation on Visual Studio 2017

This bug affects gdcm 2.4.4 at least. But I could not reproduce it with the master branch so you can consider it as solved.

After some investigations, if I disable the inlining (/Ob0) on the 4 jpeg related project, I have no more fail in the test suite. The complete list of the failing test is the following one : 138 - TestImageChangeTransferSyntax1 (Failed) slight difference +/-1 intensity 139 - TestImageChangeTransferSyntax2 (Failed) idem 140 - TestImageChangeTransferSyntax3 (Failed) idem 141 - TestImageChangeTransferSyntax4 (Failed) idem 142 - TestImageChangeTransferSyntax6 (Failed) idem 143 - TestImageChangeTransferSyntax7...

TestScanner1 failing on Windows VS 2013

TestImageChangeTransferSyntax[1-7] fail in release VS 2013

The attached patch fix this issue. I was not sure if it would not be better to put the code directly in the Printer::Print function. Fixing just the test has a lower impact perhaps.

Hi Georgios, I had a similar probleme that happened to me on couple of computers, one on Win8, 2 others on Win10. I found that the CryptoAPI is not use properly and that it is probably the issue here. At least, it fixed my failing computers. You can find the patch attached to this answer.

The tag 7FE0,0010 (Pixel Data) is in a Macro and the code that should look for it is commented (see gdcmModules.cxx line 40)