Christopher Wager

Hi Jsmie, Im a bit cofused as to why the would want to check if mod_access_compat is installed before adding the allow from all over adding only the correct directive for the new version. If you creating a new vhost you really ought to be using the correct syntax. Granted that may not be so if they are using webmin to amend vhosts that already exist but they you have a bigger problem. Intact apache even had documentation that explains using both types in the same vhost can lead to conflict and result...

Hi Jamie, If we do strace and look for the write section, we find the following error being triggered: [pid 5745] write(2, "AH00526: Syntax error on line 7 "..., 83AH00526: Syntax error on line 7 of /etc/apache2/vhosts.d/www.56kprojects.com.conf: ) = 83 [pid 5745] write(2, "Invalid command 'allow', perhaps"..., 108Invalid command 'allow', perhaps misspelled or defined by a module not included in the server configuration ) = 108 For comparison here are the .vhost files before and after my change:...

Hi Jamie, Its worth noting it might be possible to work round this on the apache server by adding the mod_access_compat module but that's not the right answer in my view webmin should understand the need for the new syntax and deal with it accordingly. In my case I'm not a huge fan of enabling legacy modules if there not needed and I would rather edit the cgi file manually as I have done than enable a compatibility module. I imagine this will be an issue for scripts related to updating the vhosts...

Hi Jamie, It included both the "allow from all" and "require all granted" in the .vhost which would cause apache to fail to start on a syntax error. Apologies for not explaining. Thanks Chris Get Outlook for Androidhttps://aka.ms/AAb9ysg From: Jamie Cameron jcameron@users.sourceforge.net Sent: Saturday, February 5, 2022 5:42:35 AM To: [webadmin:bugs] 5547@bugs.webadmin.p.re.sourceforge.net Subject: [webadmin:bugs] #5547 create_virt.cgi creates invalid .vhosts for apache 2.4 Thanks ... but how was...

Hi Jamie, It included both the "allow from all" and "require all granted" in the .vhost which would cause apache to fail to start on a syntax error. Apologies for not explaining. Thanks Chris Get Outlook for Androidhttps://aka.ms/AAb9ysg From: Christopher Wager stargazer2021@users.sourceforge.net Sent: Thursday, 30 September 2021, 07:31 To: Ticket #5508: Incorrect document section when creating vhosts. Subject: [webadmin:bugs] #5508 Incorrect document section when creating vhosts. [bugs:#5508]https://sourceforge.net/p/webadmin/bugs/5508/...

create_virt.cgi creates invalid .vhosts for apache 2.4

Incorrect document section when creating vhosts.