Thomas Orgis

Next step would be to check if a stream capture (--streamdump file) that is then opened with correct --icy-interval from disk also crashes. This isolates things from the actual HTTP process. Of course, the history of the corrupted string struct would be good

I cannot reproduce on AMD64. Is this specific to remote control mode or does plain mpg123 https://jazzradio.ice.infomaniak.ch/jazzradio-high also crash? It also prints the ICY info for me … though it is not very informative: src/mpg123 https://jazzradio.ice.infomaniak.ch/jazzradio-high High Performance MPEG 1.0/2.0/2.5 Audio Player for Layers 1, 2 and 3 version 1.33.5-dev; written and copyright by Michael Hipp and others free software (LGPL) without any warranty but with best wishes Directory: https://jazzradio.ice.infomaniak.ch/...

Can you test current trunk / snapshot? I followed the original suggestion to copy the aarch64_defs.h approach now. I've seen the sections announcing shadow stack now, but I have not tested this anywhere.

Revisiting the ID3v2 spec … there are lots of frames that I never encountered, ideas for specifc uses that did not materialize. As I said, adding text fields should be easy enough, but there is lots of funny binary frames, or things like LINK … I do not think that it is libmpg123's task to provide a full implementation of the standard. It is unfortunate that you got lots of MusicBrainz IDs stored as TXXX frames and only one of them as UFID. I am pondering how to add API for the UFID frames. It needs...

Can I keep the leading bits of your file as test data in the mpg123 distro? I guess I'll just add parsing and testing of the dump for the fields it has.

Hm, so id3v2 is not actually displaying the binary data for UFID. I thought I'd let mpg123-id3dump show it in hex. Regarding additional fields: I guess you'd like to see the URL fields (starting with W), too. Then there's TORY. There is a numer that I did not cover. Adding more text-like fields is easy. The binary ID needs some specific bits, but not such a big deal. So far there was no demand for more fields, but sure, I can add more.

Sure, mpg123's ID3 parsing is not exhaustive. It is mostly about (text) fields useful for player display. Can you give an example file and also show the id3v2 output? Seems like id3v2 doesn't actually create UFID frames. id3v2 --UFID xxx foo.mp3 does not result in anything being added to the file. So I wonder how you populate these and also, since the data is supposed to be unspecific binary, how it is to be displayed. This field seems to be designed for the same purpose that Amazon utilizes a simple...

Hm. You got a working example that does this in custom assembly files? Is the layout exactly the same on x86-64 as on ARM? What replaces __ARM_FEATURE_BTI_DEFAULT and __ARM_FEATURE_PAC_DEFAULT? I wonder how many of these annoying busywork items will crop up, making it more and more cumbersome to carry stand-alone assembly files. Maybe we need to go to inline asm, after all, at least for active architectures. We'd keep the files for 32 bit archs unchanged, I presume. But for now it is reasonable to...