Sethur

PS: I just found that fix-libgd-screen-boundary-rounding.md containes some references to a previous approach where I tried clamping the coordinates (which also worked but wasn't as clean). I have fixed that in the doc below.

Hi @sfeam, as promised, please find attached the updated clipping fix. I have tried to integrate all your suggestions and tested this thoroughly by reviewing the output of all demo scripts manually and also benchmarking it against older builds. The patch consists of two commits because I wasn't sure you wanted the additional clipping calls in place_objects(). Without them, the libgd SDF rasterizer (gd.trm) will produce some minor visual artifacts in the output of script like clipobject.dem where...

libgd: Fixes for minor issues introduced with patch 833 (dashtype support)

Hi @sfeam, as promised, please find attached the updated clipping fix. I have tried to integrate all your suggestions and tested this thoroughly by reviewing the output of all demo scripts manually and also benchmarking it against older builds. The patch consists of two commits because I wasn't sure you wanted the additional clipping calls in place_objects(). Without them, the libgd SDF rasterizer (gd.trm) will produce some minor visual artifacts in the output of script like clipobject.dem where...

Hi @sfeam, your approach is indeed much better than what I had initially proposed. It would also make it easier and clearer to implement clipping for cairo terminals. I have integrated your proposed changes into the patch and am currently testing it thoroughly. I will post it here if the tests show no issues. While testing, I have found a minor bug regarding my dashtype/antialiasing patch. There is a condition (very thick lines above lw 32 and certain sampling rates) at which small artifacts (missing...

It makes less sense for viewing on the screen, where the nominal size and the displayed size are often quite different. And in my experience you often do not know the true dpi of the eventual output device (journals used to print at something like 3000 dpi; I don't know what they do now). You only know the desired physical size. Same for displaying on a screen; you don't know in advance whether your plot will be displayed on a 95 dpi monitor or a Retina device. PS: To address this specifically: Journals...

It makes less sense for viewing on the screen, where the nominal size and the displayed size are often quite different. And in my experience you often do not know the true dpi of the eventual output device (journals used to print at something like 3000 dpi; I don't know what they do now). You only know the desired physical size. Same for displaying on a screen; you don't know in advance whether your plot will be displayed on a 95 dpi monitor or a Retina device. PS: To address this specifically: Journals...

It makes less sense for viewing on the screen, where the nominal size and the displayed size are often quite different. And in my experience you often do not know the true dpi of the eventual output device (journals used to print at something like 3000 dpi; I don't know what they do now). You only know the desired physical size. Same for displaying on a screen; you don't know in advance whether your plot will be displayed on a 95 dpi monitor or a Retina device. PS: To address this specifically: Journals...