Than Ngo

the following patch should fix the RESOURCE_LEAK and CHECKED_RETURN errors. I'm not sure to fix the Error: TAINTED_SCALA. I know we need to check the TempChar before calling fputc. diff -up dos2unix-7.4.0/common.c.me dos2unix-7.4.0/common.c --- dos2unix-7.4.0/common.c.me 2018-11-10 12:54:36.357255451 +0100 +++ dos2unix-7.4.0/common.c 2018-11-10 13:36:09.521902844 +0100 @@ -981,6 +981,7 @@ FILE* MakeTempFileFrom(const char *OutFN *fname_ret = fname_str; free(cpy); + cpy = NULL; #ifdef NO_MKSTEMP if...

important issues found by covscan

the patche causes the following errors when the user calls "make check" in the build process. In my opinion it's an regression. FAIL: uid_utils_000 (process:12112): t-CRITICAL **: uid_utils.c:483: uid map file directory '/var/lib/openhpi' does not exist. Either re-install the package or create the directory maunally. (process:12112): t-WARNING **: uid_utils.c:174: UID map file directory does not exist. FAIL uid_utils_000 (exit status: 1) FAIL: uid_utils_001 (process:12119): t-CRITICAL **: uid_utils.c:483:...

Coverity Scan detects several issues: Defect type: STRING_OVERFLOW openhpi-3.7.0/plugins/oa_soap/oa_soap_oa_event.c:611: fixed_size_dest: You might overrun the 255-character fixed-size string "temp->server" by copying "nw_info->ipAddress" without checking the length. openhpi-3.7.0/plugins/oa_soap/oa_soap_oa_event.c:611: parameter_as_source: Note: This defect has an elevated risk because the source argument is a parameter of the current function. o 609| wrap_g_mutex_lock(temp->mutex); o 610| memset(temp->server,...

Coverity Scan detects several issues

hpisettime set a wrong time on ppc64 platform