Bolivar immediately boosts the liberty in the colony by 20%, so some increase in ability to add colonists is to be expected. I note you did not attach a saved game, without which I can not check if what you are seeing is excessive.
I note with amusement that the $ was added in response to a previous request which called for some quick indicator that you had not scouted here yet. Apparently we can not please everyone.
It is indeed wrong, but temporary. FreeCol is a client-server system. The display does not get updated until the client sends a message to the server accepting the new region name, and the server sends back an update for the tiles that have changed. Until that message arrives, the region naming is unconfirmed and unchanged. Keeping the client and server in sync is VERY important, and the source of many game breaking bugs, whereas a brief display error on the region name is a minor annoyance.
Yes, I know. What I am trying to ask is whether the comments in the Messages.getUnitLable would work for your use case if we rewrote the function so that it used translatable strings for each case, initially containing those comments for English.
I assume it to be the latter reason, simply because it increases the colony defence.
...and I was wrong again. Producing hammers into an empty build queue is allowed. I think it should not happen, but it is easy to avoid so of minor impact. Therefore I am reclassifying this as an IR to remind someone (hopefully myself) to fix it.
Ticket moved from /p/freecol/bugs/3261/
Suffered a big savegame corruption error
Looks like the same OOM issue in BR#3304, but Stian has mitigated it in trunk. Closing as Duplicate.
When I unpack the attached save file, the savegame.xml part of it (the important bit) has zero size (freecol saved games are just .jar files with a .fsg suffix). If there is a freecol bug here (not certain, is your filesystem at 100% full?) the error occurred when you saved the game. It should have been noted in FreeCol.log, which on rational linuxes will be in ~/.cache/freecol by default. Beware this is likely to be overwritten every time you start freecol without command line override with the...
Apply pre-build production at end of turn, BR#3261.
There are actually two bugs here, and the end-of-turn-in-colony code is very tricky. In git.fcd04a5b the colony now consumes 8 lumber. I now believe I was wrong about 7, apparently production overflow is intended to happen, and yes, that is a good thing to fix in FreeCol2. The second bug is that after the turn ends, the new Lumber Mill is shown to be producing hammers although the colony is not building anything. Looking at that next.
The problem is that when the building upgrade fires it increases the production from 8 to 14 hammers and that this is still applied despite the build queue now being empty. I have probably never seen this due to rarely having an empty build queue in an early stage colony where it is noticeable. I believe that 7 lumber should be consumed.
Drop warning, no regression seen for old bug for some time.
Further string refinement, BR#3285.
"Arctic and Antarctic circles" sort of works, but we do not show them on the map so that may be confusing. I have compromised with "near the polar regions".
GOTO orders continuing after colony management screen opens
The goto-orders code has changed significantly lately, and I can no longer reproduce this problem with the current trunk. I will close this bug now, but keep an eye on it because I agree it is wrong and annoying.
Disable accept button when trade conditions change.
Exception when saving options after language change
Checked again, the message appears. There is still an issue with the MainPanel, where a change to the language using the Preferences button does not update the MainPanel when you return to it (unsurprising, its still the same panel instance). I think this is pretty minor, as any further panels are now in the correct language. Closing.
Error "The server can not do that." when trying to haggle over the selling price
Drop trace.
I think you would be ill advised to trust my view on aesthetic matters. Have we tried making them half-grey?
Congress is filled too quickly
Its been many years without further evidence that there was a bug here. Closing.
What Would Col1 Do?
git.543cfbfa changes the national labels in the places you mention. Unfortunately, the routine that has changed is called in other places, so other things may now break. We shall see. Try "Neu-Holländer" Confirmed, however this is a very different problem. One issue per bug report please, multiple reports complicate tracking.
Use country label more widely, BR#3288.
Drop another autosave trace.
Another event thread fix.
Prevent NPE with old game load.
Another event thread fix.
I can not reproduce this with the current development build. There have been a few hang-game bugs fixed recently, perhaps this was one of them.
Native settlements can generate on arctic tiles
I doubt it was intended. However when the various climate settings were added to the map generator it was understood that you could abuse them to get odd results, and that there was no interest in preventing users from generating weird maps.
"High magnitude latitudes" Would you prefer "polar latitudes"? English is not giving me much choice between technical and inaccurate while being concise. it's not clear what is meant with "usually"....it would be nice if the Colopedia texts would adapt to changes in the rules I think the intent of the Colopedia text is to warn that settling the polar regions is going to be impractical most of the time. We already do not precisely define what it means to "support colonies" --- does it count as supported...
Have a look at Messages.getUnitLabel(). It is ugly, but there are strings there in comments that might be what you are after. Let us know if you think that would work.
I do not think this is a bug. Odd stuff happens with you mess with the map generator. Let the user beware. Think of it as a historical emulation of the vikings in Greenland failing where the Inuit survived.
FTBFS tbuild failure with java11
Fixed in git.49c2a62.
Revert getLongThreadID use, its not present in Java 11.
getLongThreadID was introduced yesterday because it fixes a deprecation warning. However we should be conservative about increasing the java version, we have done enough of that recently. I will revert and live with the warning.
Ticket moved from /p/freecol/improvement-requests/242/
Bad message label, BR#3295.
Missing text in Europe trading context menu
Never noticed that... I always just drag the goods. Fixed in git.6f399d4.
Disagree. The region name update is delayed but many things cause it to update, including just moving another unit.
Passing over the Colopedia issues, I am not familiar with the code there. Disagree on the missing spaces in the town window and work menu. "Qosqo, Inca Capital (Hateful)$" Working as designed. The $ is an indication that you should consider sending a scout there. It goes away if you do.
Fixed in git.3856bae.
Several misleading/incorrect terrain texts
Text fixes, BR#3285.
Ticket moved from /p/freecol/bugs/3283/
Drop trace for autosave bug.
The autosave problem should be gone following sufficient detail being given in BR#3276.
autosave oddness
changed work directory on loading or saving
Thank you for giving enough detail to explain how this happens. It just never occurred to me to load directly from the autosave directory. I have changed this in git.e63ce19 to prevent autosave directories being created in autosave directories. That said... in those cases the save directory and the autosave directory will be the same, which I am not convinced is a good thing, but hopefully less harmful.
Prevent autosave-in-autosave, BR#3276.
High scores are not being tracked
Ship not exploring when going to Europe
Can not reproduce. Please attach a saved game where this happens and state which tile you expect to see explored.
Icon for ship repaired message in the turn report incorrect
I have only a vague idea why this could happen, but have added an experimental fix in git.aca9e63. If it happens again, please attach a saved game from the previous turn. That would make it possible to debug rather than us having to make vague guesses.
Try to improve unit repair location, BR#3271.
Not seeing a saved game. Nor have I seen this happen.
I can not reproduce this. Attaching a saved game might help with the first case.
Trade Problem 1
Trade Problem 2
Should be fixed in git.6aaa722.
Colony gains production bonus incorrectly
Add a helper for the RebelToolTip that correctly finds the next/50%/100% bonus turn numbers, BR#3217.
Untangle the SoL/Tories mess.
Finally getting back to this. The SoL percentage is correct, you may be missing that Bolivar is present, which boosts SoL by 20%. What is broken is the number of turns to reach next bonus change calculations. They are also not accounting for Bolivar.
Escape breaks out of FreeColPanels, BR#3035.
Broken key mapping for closing panels
Its been a while, but should be fixed in git.9f1cf3a.
setCancelComponent was a noop, removed.
Missing strings for audio volume option.
Incorrect saves
AFAICT this has been fixed at some point in the past 5 years. I just created a map with 10 cities, saved, restored, and saw no problems.
Preferences being reset
The keyboard accellerators were still broken in 0.12.0 but were fixed recently with BR#3267.
Fix deprecation warning.
Title "King" is still used sometimes
Mostly agreed. I have replaced king with "monarch" and "crown" in several of these cases, and thank you for the "Hurrah!" suggestion. However I am inclined to leave "Kings Regular" alone as they were in Col1, and individual regiments have connections to specific monarchs who may not necessarily be alive, so this is not necessarily wrong even when the monarch of the day is female. See git.7a914ea.
Replace use of "king", BR#3286.
Drop some "%nation% nation" strings as they look bad if the nation is the REF, BR#3296.
Bad message: "Royal Expeditionary Force nation"
Should be fixed in git.4ea1dda.
Back down folks. Audio volume is adjustable in game, as it always has been. Perhaps it is not as discoverable as one might like under the Preferences entry in the Game menu tab, but it works.
Game menu, Preferences, Audio, volume slider. Works for me.
Try it. I think you will be pleasantly surprised, at least in the FreeCol ruleset.
Quash NPE in addNewUnitToTile.
Are anyone actually using the classic map controls (intentionally)? Not I. IIRC when the new ones were introduced there were some hold out users, but that is a while back now. We should either just remove the classic map controls or invest some time into making it better. For example, switching map control should have immediate effect rather than requiring a restart. +1 for removal, the code complication is a pain.
Confirmed. IIRC there were problems with this some time ago, and the developer who was working on it disabled it "temporarily". Looks like it never made it back in. Will look into it.
Prevent NPE if trying to set a playlist with sound turned off.
Multiplayer not Loadable
Please upload the saved game. That will make the bug easier to reproduce.
No edit button for difficulty levels