Yep that fixed it, thanks again.
Looks good now! I re-ran all of the non-destructive tests you suggested to me on https://sourceforge.net/p/dump/feature-requests/16/, and everything appears to be working. One last request (not pressing) while I am being annoying: on Gentoo, we are disabling link-time optimization (LTO) for dump because it fails to build with CFLAGS="-Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing" all of which tend to indicate problems that could confuse LTO. If this is easy to fix, it may avoid some...
dump itself builds OK on that branch, but faketape/dump-info.cpp is missing sys/stat.h: g++ -DHAVE_CONFIG_H -I. -I.. -D_USE_BSD_SIGNAL -D_PATH_DUMPDATES=\"/usr/local/etc/dumpdates\" -D_DUMP_VERSION=\"0.4b53\" -D_PATH_RMT=\"/etc/rmt\" -O3 -pipe -mabi=lp64d -march=rv64gc -W -Wall -std=c++20 -MT dump-info.o -MD -MP -MF .deps/dump-info.Tpo -c -o dump-info.o dump-info.cpp dump-info.cpp: In function 'std::string getmode(uint16_t)': dump-info.cpp:194:23: error: 'S_IFMT' was not declared in this scope 194...
compatglob fails to build with newer compilers
Include endian.h in faketape/bswap_header.h
Thank you both!
Control stack regression with abs_integrate / 5.48.0
No problem, happy to help. Thanks for investing the time to make dump more portable!