hi works with a fresh freebsd13 on my ( old ) Dell - Server, but not tested in production yet, whereas the patch#1 still does a good job
... I think, I have to create one more test-machine ...
https://www.cisco.com/c/en/us/td/docs/ios-xml/ios/bbdsl/configuration/xe-3s/asr1000/bba-xe-3s-asr1000-book/bba-cos-ppp-pppoe-xe.pdf
the number of ( unwanted ) disconnects seems to decrease. :-) compared to a Mikrotik PPPoE. Without the patch there's no difference. But I should watch the number of disconnects a few days more. Until now, I found only on Cisco-Routers the possibilty to adjust the VLAN-prio settings for LCP-Control-Packets.
I put it online, with a backup PPPoE-Server, of course. In a few days I can do some statistics about PPPoE - disconnects
in the first patch I disabled the code lines concerning sysctl and set pcp = 7 --> (uint8_t )(mtag + 1) = 7; that's working! Every lcp echo request comes now with nework - control - prority
tcpdump -i bce1 -nv -s0 -w /tmp/bce1.pcap and --> wireshark
still no luck, something like "pass out from x.y.z.1 to any set prio 6" within pf.conf for e.g. VoIP works for VLAN + PPPoE encapsulated packets I do an tcpdump from the "bceX" - Interface...