I have PRed the patch at https://github.com/xmlstarlet/xmlstarlet/pull/22 - will need user testing and review. It is now passing the tests. please check out the update I needed to make to the test.
I have PRed gholk patch at https://github.com/xmlstarlet/xmlstarlet/pull/22 - will need user testing and review. It is passing the tests. @gholk
only impacts 2.12.0 though 2.12.2 due to 7f767866 ("Fix downstream build issues after reworking globals.h"). Not needed since 2.12.3
I've been working on cleaning up our LibreELEC repo and making sure patches get upstreamed where possible. We use xmlstarlet as part of our tooling, and this issue kept coming up, so with some time to spare I put together https://github.com/xmlstarlet/xmlstarlet — starting with CI/GHA and then working through the build errors and warnings. Hope this is of some interest. All platform builds are now succeeding. There are some trivial warnings and future deprecations still to address.
Fix build of 3.101 (utf8)
pngcp: fix -Wreturn-type warning in better_options
retested with 26.00 release and gcc-16-20260208 below is the error output. In file included from ../../Archive/../../Common/Common.h:11, from ../../Archive/StdAfx.h:9, from ../../Archive/HandlerCont.cpp:3: In destructor 'CLocalProgress::~CLocalProgress()', inlined from 'virtual ULONG CLocalProgress::Release()' at ../../Archive/../Common/ProgressUtils.h:11:1, inlined from 'CMyComPtr<T>::~CMyComPtr() [with T = ICompressProgressInfo]' at ../../Archive/../Common/../../Common/MyCom.h:17:37, inlined from...
retain const qualifier from pointer