This must have been broken by when cleaning up the startup sequence. It should pop up a KAuth prompt to create and chown portage:portage /var/cache/kuroo . Unfortunately we won't be able to fix this soon on account of leaving for several months and not bringing a computer with. It'll probly be at least October before we even get a chance to look at the code again, and the port to KF6 / Qt6 will also need to be done at the same time.
app-portage/kuroo-9999 is installing files in root folder
This has been fixed a while ago by using XDG dirs.
Kuroo relies on deprecated variables in make.conf for directory settings
Implemented repos.conf parsing and several other things in release 1.2.3 which is pending being added to the gentoo tree at https://bugs.gentoo.org/936066 . The main release notes are: Notably this version reads repo locations from /etc/repos.conf per bug #64 filed at sourceforge, and bug 934211 filed at gentoo. It also adds some warnings and more messaging around errors and warnings. Lots of cleanup in CMakeLists and other old code. Rename base name to org.gentoo.kuroo. Add a warning to the config...
Release version 1.2.3
Parse repo locations from repos.conf: part 3
Parse repo locations from repos.conf: part 3
Parse repo locations from repos.conf: part 2
Parse repo locations from repos.conf: part 1
Minor cleanup of some of the file processing
Remove old Message class
Handle errors in Emerge::queue
Rename all the auth-helper things to org.gentoo.kuroo
Significant work on CMakeLists and cleanup KAboutData
Mark PORTAGE_BINHOST and SYNC vars deprecated in config
Use plain CPP static for regexes, pass m_parent to more dialogs
Minor syntactic adjustments
Add warning to ConfigDialog
Kuroo relies on deprecated variables in make.conf for directory settings
Hi Matthias, thanks for the report! This is a known thing but has kinda been forgotten since it "just works"™ here because PORTDIR has been set for ages (and the tree is still in /usr/portage instead of /var/db/repos). There are a lot of projects in the kuroo codebase and this one has just never been prioritized, but it shouldn't be too difficult to do, just slightly annoying because the repos.conf files use "ini" syntax rather than variable assignment syntax like most other files we read. Will try...
Replace some QLatin1Strings and QLatin1Chars
Clean up some stale code in QueueListModel
Fix a couple of memory leaks reported by ASAN
A few extra QStringLiterals and QLatin1Chars
Don't quote size when inserting into the cache table so that SQLite will have an easy job knowing that it is an integral value rather than a string.
Update min QT/KF versions in CMakeLists to show deprecation warnings in preparation for KF6.
Adjust the column widths in the PortageTab package summary area so it doesn't wrap awkwardly.
Pass the parent QObject to KMessageBox calls in emerge so that the dialog can be centered.
Cleanup stale commented out code, comment some existing things, remove unnecessary forward declarations and includes.
Convert cache.size column in DB to INTEGER type.
Port to `KMessageBox::{question,warning}TwoActions` instead of `*YesNo`.
Cleanups mostly for Clazy range-loop-detach, container-anti-pattern,
Declare a local `const QStringList` to prevent detach and solve the clazy warning in `KurooHelper::writeworld`
New ebuilds for 1.2.2 and 9999
Making a new release for kuroo-1.2.2
Release 1.2.2
Update QT, KF, and ECM versions.
Include the revision in the version for places that don't handle sub-revisions specially. Fixes a lot of things broken by the previous global.cpp parsePackage rewrite particularly ebuild display in package inspector, installed versions in details, and unmerge of packages with sub-revisions.
Pass the QWidget parent through to Emerge so that it can be used to center dialogs.
Specify horizontal for progress bars in queue list so they fill the space.
Fix lots of deprecation and code style warnings.
app-portage/kuroo-9999 is installing files in root folder
Fixed in r1725
Fix bug #63. PhobosK actually did all the research about the deprecated variables and new variable names.
Sorry, meant the files didn't belong there. This bug is definitely appropriate and serious, thank you for filing it. On 9/25/21 12:28 AM, PhobosK wrote: Well.., sorry if you feel that this doesn't belong here, but I didn't have time to look deeper into this and It seemed an upstream cmake config problem, so I decided that this is the best place to be fixed. Emerge and the ebuild has nothing to do with it, since they are pretty straightforward. Now as I had a little more time, turns out it is really...
That absolutely doesn't belong there. Must be something weird going on in CMake. Would you mind posting emerge --info? On 9/24/21 12:00 PM, PhobosK wrote: [bugs:#63] https://sourceforge.net/p/kuroo/bugs/63/ app-portage/kuroo-9999 is installing files in root folder Status: open Group: default Created: Fri Sep 24, 2021 07:00 PM UTC by PhobosK Last Updated: Fri Sep 24, 2021 07:00 PM UTC Owner: nobody There is a problem with the installation of app-portage/kuroo-9999. It creates and adds folders in root...
Reimplement CachePortageJob to work with Manifest2 format (GLEP 44).
Save the updated TODO since it hasn't gone to VCS in a while. Add the new ebuilds for posterity and clean up some old.
Gentoo Bug #811693: Clean up CMakeFiles.txt and ebuild
Update branch / tarball name in release cutting script.
Making a new release for kuroo-1.2.1
Fix crash in CachePortageJob from parsePackage.
A "minor optimization" from a clang-tidy error of parsePackage actually broke things, restore the previous behavior while still solving the clang-tidy complaint.
Making a new release for kuroo-1.2.0
Release 1.2.0 with lots of code cleanups and strict compiler settings.
Making a new release for kuroo-1.1.0
Release 1.1.0 with first implementation of deferred authorization via KAuth and lots of code cleanup.
Qt6 wants all QLatin1Char('<char>')s to be just u'<char>'.
Most of the fixups from clazy levels 1 and 2.
Clazy convert remaining Qt magic keywords into (presumably) macros so that all the strict compiler settings in ECM 5.85 can be enabled finally.
Clang-tidy performance fixups: don't copy const loop variables or method args, use const ref instead.
Fixups from hicpp and bugprone checks:
More modernization and readability fixups:
Reasonable fixups from the readability group:
Include sorting changed after libc includes changed.
Clang-tidy modernize-* fixups do lots of interesting things:
Hopefully the last of the else-after-returns, and one narrowing cast.
A bunch more else-after-returns.
More import sorting and cleaning from clang-tidy llvm-* fixups.
More clang-tidys: several else-after-(return|break|continue), include sorting (where it didn't mangle things, and removing apparently unnecessary includes in places where it did mangle but compile still succeeded. Will run include-what-you-use again eventually).
This should be the last set of initializing things that aren't initialized in the constructor.
More clang-tidyings: empty curly braces after the declaration of members that aren't initialized by the constructor. De-virtualize things that are overridden because it's redundant. Strictly init ints and bools to 0 rather than trusting that they'll be 0 just because. Similarly with some pointers. Use dynamic instead of static cast when casting objects down to more-derived types.
Clang found yet more NULLs to change to nullptrs. And for some reason added empty curly braces after some variable declarations? And de-virtualized a bunch of methods in queuelistmodel for as-yet-mysterious reasons, but the basics still work so we'll move on to the next cleanup.
The rest of s/NULL/nullptr/ that clang-tidy's fixer had trouble with. Some more extraneous forward declarations and a little bit of spacing.
Mostly clang-tidy s/NULL/nullptr/. A little bit of spacing and removing extraneous forward declarations.
Convert QT's foreach helper to C++11 range loops. Karye was pretty careful, the vast majority of uses clearly did not modify the container inside the loop: lots of processing text, copying between UI containers and Model containers, processing files in a directory. The riskiest places seemed to be in QueueListItem, but again, manual testing shows that the basics still work.
Whew. Enabling QT_NO_CAST_FROM_ASCII was a lot. Lots of places were just wrapping static strings and chars in QStringLiteral and QLatin1Char to make them static at compile time. And converting lots of single-char strings into actual chars, which /ought/ to be slightly easier for Qt string parsing and catenation methods to handle than a string. There are a lot of duplicates which could theoretically be moved into a single resource and then referenced across the codebase, but hopefully that'...
Commit a working state of progress on QT_NO_CAST_FROM_ASCII. Still more to go but the diff is getting pretty big. The big notable change is that `kurooDir` is no longer a pointer, just static const in scope everywhere.
Enable and fix the next set of strict compiler settings: QT_NO_CAST_FROM_BYTEARRAY.
Fix missing include dir compiler warnings.
Fix the first set of warnings from new compilersettings: 0 as null pointer arg.
Enable new KDE_COMPILERSETTINGS strictness in ECM
Making a new release for kuroo-1.1.1
Patch release 1.1.1 with fixed desktop file,
Making a new release for kuroo4-1.1.1
Release 1.1.1 with corrected desktop file.
Don't launch with kdesu any more.
Making a new release for kuroo4-1.1.0
Release 1.1.0 with first pass of polkit deferred auth actions
Clean up the "you must run as root" dialogs so that it isn't misleading when using deferred authorization.
Fix the minimum version warning in CMakeLists.txt.
s/eProc->pid()/eProc->processId()/ because of deprecation.
Implement add to / remove from world in helper.
Major work on port to KAuth. Implement quickpkg in helper.
Convert the remainder of SIGNAL() and SLOT() invocations to function pointers for static type-checking
The barest minimumest functionality now works via KAuth, allowing a non-superuser to run Kuroo and
Fix a dumb typo in setHelperId in the previous checkin. Unfortunately I confirmed that:
Yet another attempt at using KAuth to be able to run unprivileged and do superuser things in an authed helper.
Config screen too tall