Activity for A Schenck

  • A Schenck A Schenck posted a comment on ticket #65

    This must have been broken by when cleaning up the startup sequence. It should pop up a KAuth prompt to create and chown portage:portage /var/cache/kuroo . Unfortunately we won't be able to fix this soon on account of leaving for several months and not bringing a computer with. It'll probly be at least October before we even get a chance to look at the code again, and the port to KF6 / Qt6 will also need to be done at the same time.

  • A Schenck A Schenck modified ticket #63

    app-portage/kuroo-9999 is installing files in root folder

  • A Schenck A Schenck posted a comment on ticket #63

    This has been fixed a while ago by using XDG dirs.

  • A Schenck A Schenck modified ticket #64

    Kuroo relies on deprecated variables in make.conf for directory settings

  • A Schenck A Schenck posted a comment on ticket #64

    Implemented repos.conf parsing and several other things in release 1.2.3 which is pending being added to the gentoo tree at https://bugs.gentoo.org/936066 . The main release notes are: Notably this version reads repo locations from /etc/repos.conf per bug #64 filed at sourceforge, and bug 934211 filed at gentoo. It also adds some warnings and more messaging around errors and warnings. Lots of cleanup in CMakeLists and other old code. Rename base name to org.gentoo.kuroo. Add a warning to the config...

  • A Schenck A Schenck committed [r1760] on Code

    Release version 1.2.3

  • A Schenck A Schenck committed [r1759] on Code

    Parse repo locations from repos.conf: part 3

  • A Schenck A Schenck committed [r1758] on Code

    Parse repo locations from repos.conf: part 3

  • A Schenck A Schenck committed [r1757] on Code

    Parse repo locations from repos.conf: part 2

  • A Schenck A Schenck committed [r1756] on Code

    Parse repo locations from repos.conf: part 1

  • A Schenck A Schenck committed [r1755] on Code

    Minor cleanup of some of the file processing

  • A Schenck A Schenck committed [r1754] on Code

    Remove old Message class

  • A Schenck A Schenck committed [r1753] on Code

    Handle errors in Emerge::queue

  • A Schenck A Schenck committed [r1752] on Code

    Rename all the auth-helper things to org.gentoo.kuroo

  • A Schenck A Schenck committed [r1751] on Code

    Significant work on CMakeLists and cleanup KAboutData

  • A Schenck A Schenck committed [r1750] on Code

    Mark PORTAGE_BINHOST and SYNC vars deprecated in config

  • A Schenck A Schenck committed [r1749] on Code

    Use plain CPP static for regexes, pass m_parent to more dialogs

  • A Schenck A Schenck committed [r1748] on Code

    Minor syntactic adjustments

  • A Schenck A Schenck committed [r1747] on Code

    Add warning to ConfigDialog

  • A Schenck A Schenck modified ticket #64

    Kuroo relies on deprecated variables in make.conf for directory settings

  • A Schenck A Schenck posted a comment on ticket #64

    Hi Matthias, thanks for the report! This is a known thing but has kinda been forgotten since it "just works"™ here because PORTDIR has been set for ages (and the tree is still in /usr/portage instead of /var/db/repos). There are a lot of projects in the kuroo codebase and this one has just never been prioritized, but it shouldn't be too difficult to do, just slightly annoying because the repos.conf files use "ini" syntax rather than variable assignment syntax like most other files we read. Will try...

  • A Schenck A Schenck committed [r1746] on Code

    Replace some QLatin1Strings and QLatin1Chars

  • A Schenck A Schenck committed [r1745] on Code

    Clean up some stale code in QueueListModel

  • A Schenck A Schenck committed [r1744] on Code

    Fix a couple of memory leaks reported by ASAN

  • A Schenck A Schenck committed [r1743] on Code

    A few extra QStringLiterals and QLatin1Chars

  • A Schenck A Schenck committed [r1742] on Code

    Don't quote size when inserting into the cache table so that SQLite will have an easy job knowing that it is an integral value rather than a string.

  • A Schenck A Schenck committed [r1741] on Code

    Update min QT/KF versions in CMakeLists to show deprecation warnings in preparation for KF6.

  • A Schenck A Schenck committed [r1740] on Code

    Adjust the column widths in the PortageTab package summary area so it doesn't wrap awkwardly.

  • A Schenck A Schenck committed [r1739] on Code

    Pass the parent QObject to KMessageBox calls in emerge so that the dialog can be centered.

  • A Schenck A Schenck committed [r1738] on Code

    Cleanup stale commented out code, comment some existing things, remove unnecessary forward declarations and includes.

  • A Schenck A Schenck committed [r1737] on Code

    Convert cache.size column in DB to INTEGER type.

  • A Schenck A Schenck committed [r1736]

    Port to `KMessageBox::{question,warning}TwoActions` instead of `*YesNo`.

  • A Schenck A Schenck committed [r1735]

    Cleanups mostly for Clazy range-loop-detach, container-anti-pattern,

  • A Schenck A Schenck committed [r1734]

    Declare a local `const QStringList` to prevent detach and solve the clazy warning in `KurooHelper::writeworld`

  • A Schenck A Schenck committed [r1733]

    New ebuilds for 1.2.2 and 9999

  • A Schenck A Schenck committed [r1732]

    Making a new release for kuroo-1.2.2

  • A Schenck A Schenck committed [r1731]

    Release 1.2.2

  • A Schenck A Schenck committed [r1730]

    Update QT, KF, and ECM versions.

  • A Schenck A Schenck committed [r1729]

    Include the revision in the version for places that don't handle sub-revisions specially. Fixes a lot of things broken by the previous global.cpp parsePackage rewrite particularly ebuild display in package inspector, installed versions in details, and unmerge of packages with sub-revisions.

  • A Schenck A Schenck committed [r1728]

    Pass the QWidget parent through to Emerge so that it can be used to center dialogs.

  • A Schenck A Schenck committed [r1727]

    Specify horizontal for progress bars in queue list so they fill the space.

  • A Schenck A Schenck committed [r1726]

    Fix lots of deprecation and code style warnings.

  • A Schenck A Schenck modified ticket #63

    app-portage/kuroo-9999 is installing files in root folder

  • A Schenck A Schenck posted a comment on ticket #63

    Fixed in r1725

  • A Schenck A Schenck committed [r1725]

    Fix bug #63. PhobosK actually did all the research about the deprecated variables and new variable names.

  • A Schenck A Schenck posted a comment on ticket #63

    Sorry, meant the files didn't belong there. This bug is definitely appropriate and serious, thank you for filing it. On 9/25/21 12:28 AM, PhobosK wrote: Well.., sorry if you feel that this doesn't belong here, but I didn't have time to look deeper into this and It seemed an upstream cmake config problem, so I decided that this is the best place to be fixed. Emerge and the ebuild has nothing to do with it, since they are pretty straightforward. Now as I had a little more time, turns out it is really...

  • A Schenck A Schenck posted a comment on ticket #63

    That absolutely doesn't belong there. Must be something weird going on in CMake. Would you mind posting emerge --info? On 9/24/21 12:00 PM, PhobosK wrote: [bugs:#63] https://sourceforge.net/p/kuroo/bugs/63/ app-portage/kuroo-9999 is installing files in root folder Status: open Group: default Created: Fri Sep 24, 2021 07:00 PM UTC by PhobosK Last Updated: Fri Sep 24, 2021 07:00 PM UTC Owner: nobody There is a problem with the installation of app-portage/kuroo-9999. It creates and adds folders in root...

  • A Schenck A Schenck committed [r1724]

    Reimplement CachePortageJob to work with Manifest2 format (GLEP 44).

  • A Schenck A Schenck committed [r1723]

    Save the updated TODO since it hasn't gone to VCS in a while. Add the new ebuilds for posterity and clean up some old.

  • A Schenck A Schenck committed [r1722]

    Gentoo Bug #811693: Clean up CMakeFiles.txt and ebuild

  • A Schenck A Schenck committed [r1721]

    Update branch / tarball name in release cutting script.

  • A Schenck A Schenck committed [r1720]

    Making a new release for kuroo-1.2.1

  • A Schenck A Schenck committed [r1719]

    Fix crash in CachePortageJob from parsePackage.

  • A Schenck A Schenck committed [r1718]

    A "minor optimization" from a clang-tidy error of parsePackage actually broke things, restore the previous behavior while still solving the clang-tidy complaint.

  • A Schenck A Schenck committed [r1717]

    Making a new release for kuroo-1.2.0

  • A Schenck A Schenck committed [r1716]

    Release 1.2.0 with lots of code cleanups and strict compiler settings.

  • A Schenck A Schenck committed [r1715]

    Making a new release for kuroo-1.1.0

  • A Schenck A Schenck committed [r1714]

    Release 1.1.0 with first implementation of deferred authorization via KAuth and lots of code cleanup.

  • A Schenck A Schenck committed [r1713]

    Qt6 wants all QLatin1Char('<char>')s to be just u'<char>'.

  • A Schenck A Schenck committed [r1712]

    Most of the fixups from clazy levels 1 and 2.

  • A Schenck A Schenck committed [r1711]

    Clazy convert remaining Qt magic keywords into (presumably) macros so that all the strict compiler settings in ECM 5.85 can be enabled finally.

  • A Schenck A Schenck committed [r1710]

    Clang-tidy performance fixups: don't copy const loop variables or method args, use const ref instead.

  • A Schenck A Schenck committed [r1709]

    Fixups from hicpp and bugprone checks:

  • A Schenck A Schenck committed [r1708]

    More modernization and readability fixups:

  • A Schenck A Schenck committed [r1707]

    Reasonable fixups from the readability group:

  • A Schenck A Schenck committed [r1706]

    Include sorting changed after libc includes changed.

  • A Schenck A Schenck committed [r1705]

    Clang-tidy modernize-* fixups do lots of interesting things:

  • A Schenck A Schenck committed [r1704]

    Hopefully the last of the else-after-returns, and one narrowing cast.

  • A Schenck A Schenck committed [r1703]

    A bunch more else-after-returns.

  • A Schenck A Schenck committed [r1702]

    More import sorting and cleaning from clang-tidy llvm-* fixups.

  • A Schenck A Schenck committed [r1701]

    More clang-tidys: several else-after-(return|break|continue), include sorting (where it didn't mangle things, and removing apparently unnecessary includes in places where it did mangle but compile still succeeded. Will run include-what-you-use again eventually).

  • A Schenck A Schenck committed [r1700]

    This should be the last set of initializing things that aren't initialized in the constructor.

  • A Schenck A Schenck committed [r1699]

    More clang-tidyings: empty curly braces after the declaration of members that aren't initialized by the constructor. De-virtualize things that are overridden because it's redundant. Strictly init ints and bools to 0 rather than trusting that they'll be 0 just because. Similarly with some pointers. Use dynamic instead of static cast when casting objects down to more-derived types.

  • A Schenck A Schenck committed [r1698]

    Clang found yet more NULLs to change to nullptrs. And for some reason added empty curly braces after some variable declarations? And de-virtualized a bunch of methods in queuelistmodel for as-yet-mysterious reasons, but the basics still work so we'll move on to the next cleanup.

  • A Schenck A Schenck committed [r1697]

    The rest of s/NULL/nullptr/ that clang-tidy's fixer had trouble with. Some more extraneous forward declarations and a little bit of spacing.

  • A Schenck A Schenck committed [r1696]

    Mostly clang-tidy s/NULL/nullptr/. A little bit of spacing and removing extraneous forward declarations.

  • A Schenck A Schenck committed [r1695]

    Convert QT's foreach helper to C++11 range loops. Karye was pretty careful, the vast majority of uses clearly did not modify the container inside the loop: lots of processing text, copying between UI containers and Model containers, processing files in a directory. The riskiest places seemed to be in QueueListItem, but again, manual testing shows that the basics still work.

  • A Schenck A Schenck committed [r1694]

    Whew. Enabling QT_NO_CAST_FROM_ASCII was a lot. Lots of places were just wrapping static strings and chars in QStringLiteral and QLatin1Char to make them static at compile time. And converting lots of single-char strings into actual chars, which /ought/ to be slightly easier for Qt string parsing and catenation methods to handle than a string. There are a lot of duplicates which could theoretically be moved into a single resource and then referenced across the codebase, but hopefully that'...

  • A Schenck A Schenck committed [r1693]

    Commit a working state of progress on QT_NO_CAST_FROM_ASCII. Still more to go but the diff is getting pretty big. The big notable change is that `kurooDir` is no longer a pointer, just static const in scope everywhere.

  • A Schenck A Schenck committed [r1692]

    Enable and fix the next set of strict compiler settings: QT_NO_CAST_FROM_BYTEARRAY.

  • A Schenck A Schenck committed [r1691]

    Fix missing include dir compiler warnings.

  • A Schenck A Schenck committed [r1690]

    Fix the first set of warnings from new compilersettings: 0 as null pointer arg.

  • A Schenck A Schenck committed [r1689]

    Enable new KDE_COMPILERSETTINGS strictness in ECM

  • A Schenck A Schenck committed [r1688]

    Making a new release for kuroo-1.1.1

  • A Schenck A Schenck committed [r1687]

    Patch release 1.1.1 with fixed desktop file,

  • A Schenck A Schenck committed [r1686]

    Making a new release for kuroo4-1.1.1

  • A Schenck A Schenck committed [r1685]

    Release 1.1.1 with corrected desktop file.

  • A Schenck A Schenck committed [r1684]

    Don't launch with kdesu any more.

  • A Schenck A Schenck committed [r1683]

    Making a new release for kuroo4-1.1.0

  • A Schenck A Schenck committed [r1682]

    Release 1.1.0 with first pass of polkit deferred auth actions

  • A Schenck A Schenck committed [r1681]

    Clean up the "you must run as root" dialogs so that it isn't misleading when using deferred authorization.

  • A Schenck A Schenck committed [r1680]

    Fix the minimum version warning in CMakeLists.txt.

  • A Schenck A Schenck committed [r1679]

    s/eProc->pid()/eProc->processId()/ because of deprecation.

  • A Schenck A Schenck committed [r1678]

    Implement add to / remove from world in helper.

  • A Schenck A Schenck committed [r1677]

    Major work on port to KAuth. Implement quickpkg in helper.

  • A Schenck A Schenck committed [r1676]

    Convert the remainder of SIGNAL() and SLOT() invocations to function pointers for static type-checking

  • A Schenck A Schenck committed [r1675]

    The barest minimumest functionality now works via KAuth, allowing a non-superuser to run Kuroo and

  • A Schenck A Schenck committed [r1674]

    Fix a dumb typo in setHelperId in the previous checkin. Unfortunately I confirmed that:

  • A Schenck A Schenck committed [r1673]

    Yet another attempt at using KAuth to be able to run unprivileged and do superuser things in an authed helper.

  • A Schenck A Schenck modified ticket #47

    Config screen too tall

1 >