John Mullins

Thanks very much! Pushed the fix in the legacy branch. https://github.com/drfrag666/gzdoom/commit/3e9ac48e791e6ce1c99c353ec203fbe06cf0f845 I tried to set you as the author but you don't have a GitHub account so i've done a hard reset (there was another ipavlov). xd

Hi, i get an error with the internal GZDoom LZMA library. What's going on? https://github.com/drfrag666/gzdoom/runs/4342227128?check_suite_focus=true D:\a\gzdoom\gzdoom\libraries\lzma\C\LzFind.c(1606,28): error C2440: '=': cannot convert from 'void (__cdecl *)(UInt32,CLzRef *,const CLzRef *)' to 'LZFIND_SATUR_SUB_CODE_FUNC' [D:\a\gzdoom\gzdoom\build\libraries\lzma\lzma.vcxproj] D:\a\gzdoom\gzdoom\libraries\lzma\C\LzFind.c(1613,30): error C2440: '=': cannot convert from 'void (__cdecl *)(UInt32,CLzRef...

Thanks. Okay but as i mentioned removing the thread_local keyword still crashes and crashes both in 32 bit and 64 bit builds so now there's still the generic object destruction problem.

It's better to investigate this in the new legacy branch: https://github.com/drfrag666/gzdoom/tree/legacy No hacks there. There are two problems causing the crashes, one with generic object destruction and another one with destruction of thread_local objects. These are using thread_local now:: thread_local VMFrameStack GlobalVMStack; thread_local FDynLightData lightdata; static thread_local TArray<ADynamicLight*> addedLightsArray;

Some news, apparently this only happens on real 32 bit OSes (i'm on win 8.1 32 bit). On win 7 64 bit the game runs normally within the debugger (both 32 and 64 bit executables). Also another dev can debug it in Server 2012.

GZDoom hangs when run thru the debugger

I've addressed the crash in my MinGW branch with a hack but of course this is not acceptable in the official master. If someone wants to investigate this he'd need to revert the following commit or extract the source from a previous one. Still crashed without thread_local BTW. https://github.com/drfrag666/gzdoom/commit/0e25e40debaccdfe91ccdcde4c5f7a8a7d776951

I've tried a hack to prevent the crash (making some objects NULL in the VMFrameStack destructor and leaking memory ) and i also have to remove thread_local to make it work or else still crashes. #4 0x0042ca38 in ST_Endoom () at C:\DEV\vsqzdoom\src\win32\st_start.cpp:1100 C:\DEV\vsqzdoom\src\win32\st_start.cpp:1100:32931:beg:0x42ca38 In (anonymous namespace)::run() () () In msvcrt!_flushall () (C:\Windows\system32\msvcrt.dll) In msvcrt!.p.iob () (C:\Windows\system32\msvcrt.dll) In ntdll!RtlDecodePointer...