Dejan Budimir

Ok, this is not trivial. Found multiple issues with the tabbar. I'm trying minimal patches on it, slowly, but am not happy with any of it yet. I want to get rid of what seem to be race conditions. This is begging for a reimplementation. The wine source should BTW be preferred to MSDN, documentation-wise < https://source.winehq.org/git/wine.git/blob_plain/refs/heads/master:/dlls/comctl32/tab.c .

Sure, let's do that. I don't know GTK though, so I hope somebody else steps up.

Thanks Jos! I guess the reason would be the slightly different notification handling. I'll look into it tomorrow. Sorry I can't sooner.

I'm happy with this: diff --git a/scite/src/JobQueue.cxx b/scite/src/JobQueue.cxx index 1e3b168..f418a6e 100644 --- a/scite/src/JobQueue.cxx +++ b/scite/src/JobQueue.cxx @@ -260,6 +260,10 @@ void JobQueue::AddCommand(const std::string &command, const FilePath &directory, commandCurrent++; if (jobType == jobCLI) jobUsesOutputPane = true; +#if defined(_WIN32) + if (flags & jobQuiet) + jobUsesOutputPane = false; +#endif // For jobExtension, the Trace() method shows output pane on demand. } }

Note to self: the feature-request forum's editor's lack of a preview button has turned into a pain. Why the difference? Are we supposed to use the bugs forum for everything?

Stop the presses! We can do better... diff --git a/scite/win32/SciTEWin.cxx b/scite/win32/SciTEWin.cxx index 1a094a4..d4b64bc 100644 --- a/scite/win32/SciTEWin.cxx +++ b/scite/win32/SciTEWin.cxx @@ -505,14 +505,11 @@ SystemAppearance SciTEWin::CurrentAppearance() const noexcept { void SciTEWin::ReadPropertiesInitial() { SciTEBase::ReadPropertiesInitial(); - if (tabMultiLine) { // Windows specific! - const long wl = GetWindowStyle(HwndOf(wTabBar)); - ::SetWindowLong(HwndOf(wTabBar), GWL_STYLE, wl...

Ok good. This should fix the reordering issue. There are other issues with the tabbar to be looked at. But they will require a separate ticket. Dare I say a bug repor?

Again: diff --git a/scite/win32/SciTEWin.cxx b/scite/win32/SciTEWin.cxx index 1a094a4..8ed2afe 100644 --- a/scite/win32/SciTEWin.cxx +++ b/scite/win32/SciTEWin.cxx @@ -507,7 +507,7 @@ void SciTEWin::ReadPropertiesInitial() { SciTEBase::ReadPropertiesInitial(); if (tabMultiLine) { // Windows specific! const long wl = GetWindowStyle(HwndOf(wTabBar)); - ::SetWindowLong(HwndOf(wTabBar), GWL_STYLE, wl | TCS_MULTILINE); + ::SetWindowLong(HwndOf(wTabBar), GWL_STYLE, wl | TCS_MULTILINE | TCS_BUTTONS); }...