Nice find. Re: the identification string exchange, it might be helpful to explain in the code that "0:0:0:7:73:73:68:2d" maps to "SSH-" (well, technically "<NUL><NUL><NUL><BEL>SSH-") which according to RFC 4253 must be the start of all SSH identification strings. Also, do you mind if I port your code changes and unit tests to sshj? https://github.com/hierynomus/sshj/issues/354
Nice find. Re: the identification string exchange, it might be helpful to explain in the code that "0:0:0:7:73:73:68:2d" maps to "SSH-" (well, technically "<NUL><NUL><NUL><BEL>SSH-") which according to RFC 4253 must be the start of all SSH strings. Also, do you mind if I port your code changes and unit tests to sshj? https://github.com/hierynomus/sshj/issues/354