Atsushi Nakagawa

@RBRi Thanks for merging all this stuff. I'll see about making the tests smaller next time. There's still a few things I think we should do but I can't commit to it right now so it might not happen. Refactor XMLHttpRequest because I think we can get rid of the stateChangeHandler_ / loadHandler_ / errorHandler_ hacks now and just call EventTarget.fireEvent(). Refactor to get rid of unused return value code in EventListenersContainer, remove ScriptResult.combine(), and maybe EventTarget.isAborted()...

@RBRi Thanks for merging all this stuff. I'll see about making the tests smaller next time. There's still a few things I think we should do but I can't commit to it right now so it might not happen. Refactor XMLHttpRequest because I think we can get rid of the stateChangeHandler_ / loadHandler_ / errorHandler_ hacks now and just call EventTarget.fireEvent(). Refactor to get rid of unused return value code in EventListenersContainer, remove ScriptResult.combine(), and maybe EventTarget.isAborted()...

@RBRi Thanks for merging all this stuff. I'll see about making the tests smaller next time. There's still a few things I think we should do but I can't commit to it right now so it might not happen. Refactor XMLHttpRequest because I think we can get rid of the stateChangeHandler_ / loadHandler_ / errorHandler_ hacks now and just call EventTarget.fireEvent(). Refactor to get rid of unused return value code in EventListenersContainer, remove ScriptResult.combine(), and maybe EventTarget.isAborted()...

I wasn't going to do a fix for HtmlImage and HtmlScript at this time but HtmlImage turned out to be not-so-disruptive so I'm attaching the fix here. I'm also including the @NotYetImplemented patch for Window3Test.onloadScript(). This bug report is actually a precursor to another bug report / patch series I have for a problem concerning <script src="..."> execution timing w.r.t to async/deferred. This is the real problem we were experiencing before I found all these problems with events itself. I...

I wasn't going to do a fix for HtmlImage and HtmlScript at this time but HtmlImage turned out to be not-so-disruptive so I'm attaching the fix here. I'm also including the @NotYetImplemented patch for Window3Test.onloadScript(). This bug report is actually a precursor to another bug report / patch series I have for a problem concerning <script src="..."> execution timing w.r.t to async/deferred. This is the real problem we were experiencing before I found all these problems with events itself. I...

I wasn't going to do a fix for HtmlImage and HtmlScript at this time but HtmlImage turned out to be not-so-disruptive so I'm attaching the fix here. I'm also including the @NotYetImplemented patch for Window3Test.onloadScript(). This bug report is actually a precursor to another bug report / patch series I have for a problem concerning <script src="..."> execution timing w.r.t to async/deferred. This is the real problem we were experiencing before I found all these problems with events itself. I...

I wasn't going to do a fix for HtmlImage and HtmlScript at this point but HtmlImage turned out to be not-so-disruptive so I'm attaching the fix here. I'm also including the @NotYetImplemented patch for Window3Test.onloadScript(). This bug report is actually a precursor to another bug report / patch series I have for a problem concerning <script src="..."> execution timing w.r.t to async/deferred. This is the real problem we were experiencing before I found all these problems with events itself. I...

Three more fixes follow. 1. TypingTest Is https://sourceforge.net/p/htmlunit/bugs/1984/#f06d not sufficent for this? 2. CodeStyleTest.codeStyle Perhaps something like this: --- a/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java +++ b/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java @@ -154,9 +154,9 @@ public enum BrowserVersionFeatures { @BrowserFeature(IE) DOM_NORMALIZE_REMOVE_CHILDREN, - /** Indicates handler return value is only used...