Andrey Saitgalin

Hello Barry! Thanks! Andrey. Barry Alan Scott barry-scott@users.sourceforge.net schrieb am Mi. 8. Aug. 2018 um 12:26: Thanks for the review. 1. I have put Complex back in, there are some parts of that class that need to be protected with Py_LIMITED_API that use Py_complex. 2. I missed only one place that PyPackageCOntext was not under Py_LIMITED_API, fixed. commited as r394 and r395. [patches:#28] https://sourceforge.net/p/cxx/patches/28/ Supported Py_LIMITED_API* Status: pending Group: Created:...

Hello, Barry! Sorry for such a long answer. I carefully compared PyCXX trunk and our version, run tests and everything seems fine in our codebase! Thanks! I just want to comment some places in code which from my point of view could be handled more carefully. https://sourceforge.net/p/cxx/code/HEAD/tree/trunk/CXX/CXX/Python3/Objects.hxx#l970 Why have you brought Complex in Python 3 under Py_LIMITED_API ifdef? Complex numbers are available in limited api as far as I can see it in Python 3 source code....

Thanks a lot Barry! I will test all changes in our project and send a reply

Hello, Barry! Any news here?

Hello, Barry! Just a friendly reminder :)

Hello, Barry! How the things are going with this patch? This would be very useful for us, we are already using it in production libraries but it is not yet in upstream and there is no progress here. We reviewed this patch very carefully in three pairs of eyes and are really looking forward to seeing this patch accepted! :) Thanks much, Andrey

Missing constructor in compatibility mode

Cleanup