Alex Jpn

Hi, thanks for preparing r16401. That said, it seems the disable calls in showFindBar run right after alloc/init, before [findController view] is ever accessed — so navigationButton/findField are still nil (their IBOutlets only connect once the nib loads via that .view access) and the setEnabled:NO calls are no-ops. Moving that isFinding check to just after [findController view]/[findController findField] are fetched seems to fix it..

Actually it seems there is one residual case where the inline find bar still shows enabled during an in-progress search: the find bar's controls (SKFindController's findField/navigationButton) are only disabled in documentDidBeginDocumentFind:. But that controller and its view/outlets are lazily created — if the find bar hasn't been opened yet, documentDidBeginDocumentFind: disables a nil findController (no-op). If the user then opens the find bar for the first time while a search is already running,...

Thanks. This is tested on Skim 1.7.15 with macOS Tahoe 26.5.2 (Apple Silicon). When testing with the provided pdf, did you reduce the window size so that no more than one of the instances of the world "alpha" are shown on the screen? In this case, when I click left and right arrows it does not move the page so that the selected instances are visible. Screenshot attached. Per debug log I tested with, the returned rect is CGRectNull, with origin components +Inf and size (0,0). The thinking is just...

Thanks, that's reasonable. I just tested with latest upstream (up to r16396) and the disablement (and reenablement) of Find UI while async search is ongoing works well for me.

Thanks. This is tested on Skim 1.7.15 with macOS Tahoe 26.5.2 (Apple Silicon). When testing with the provided pdf, did you reduce the window size so that no more than one of the instances of the world "alpha" are shown on the screen? In this case, when I click left and right arrows it does not move the page so that the selected instances are visible. Screenshot attached. Reattached the diff too for reference. Per debug log I tested with, the returned rect is CGRectNull, with origin components +Inf...

Thanks. This is tested on Skim 1.7.15 with macOS Tahoe 26.5.2 (Apple Silicon). When testing with the provided pdf, did you reduce the window size so that no more than one of the instances of the world "alpha" are shown on the screen? In this case, when I click left and right arrows it does not move the page so that the selected instances are visible. Screenshot attached. Reattached the diff too for reference.

Inline find can silently fail to scroll to a match inside table-structured content

Thanks for the comprehensive and very reasonable feedback. Understood that concurrent searches may be risky. Let me describe a scenario I experienced, and a possible alternative approach in case you are prepared to consider it. I frequently work with large technical PDFs circa 100 MB, 10000 pages, mixture of text, equations, figures, etc. A full async search (left pane) for a term might take 30 secs to complete in some cases. In the mean time, the user might try using the right-side sync Find to...