Adding support for optional JNI 1.4 functions

Patch, description, test and statement of origin

Logged In: YES
user_id=1215435

great!

I'll have to take a look at the Address=> int change. I
suspect this won't work for us since we run Jikes RVM on 64
bit platforms, but I'll have to look through the code path
to be sure.

Logged In: YES
user_id=648271

I think the int is fine since it's not an address but a JNI
reference as returned from env.pushJNIRef. For example, the
NewObject JNI function also return an int, regardless of
platform, as returned from env.pushJNIRef.

What I was worried about was some kind of odd ABI
dependency on the Address return type I don't know about.

• elias

Logged In: YES
user_id=308843

I think in:

rvm/src/vm/libSupport/gnu/classpath/JikesRVMSupport.java

• //-#if RVM_FOR_32_ADDR
• return new Pointer32(address.toInt());
• //-#elif RVM_FOR_64_ADDR
• return new Pointer32(address.toLong());
• //-#endif

should be:

• //-#if RVM_FOR_32_ADDR
• return new Pointer32(address.toInt());
• //-#elif RVM_FOR_64_ADDR
• return new Pointer64(address.toLong());
• //-#endif

I agree the int looks funny, but I also agree we do it
elsewhere :-)

Regards,
Ian

Logged In: YES
user_id=648271

Yes, I fixed the Pointer32 issue in the second upload of
the patch a few minutes later than the original patch. I'm
sorry you got the patch too soon :)

Logged In: YES
user_id=1215435

ok, makes sense...I should read the patch before commenting
next time :)

Regression testing now; should commit later this morning.