All instances of SCLstring changed to std::string
Open Source Solid Modeling CAD
Brought to you by:
brlcad
Menu
▾
▴
#68 All instances of SCLstring changed to std::string
I've changed all instances of SCLstring to std::string, in places this also involved changing SCLstring class functions to their std::string equivalent. A frequent example is changing something like:
s.Append(c)
to
s += c
Here, s was a SCLstring object, and we changed it to a std::string and used std::string's overloaded += to append the single char c
There were other things (replacing SCLstring's set_null() with std::string's clear() etc.,)
Compiled successfully using cmake version 2.8.5
compiler info:
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/i686-pc-linux-gnu/4.6.0/lto-wrapper
Target: i686-pc-linux-gnu
Configured with: ./configure
Thread model: posix
gcc version 4.6.0 (GCC)
This patch was written for revision 45582
Made with svn diff
Zach, that is just phenomenal, awesome work!
Impressive to say the least and highly useful.. We're actively working on STEP support enhancements, so this is quite timely too. I'll give testing a go here tomorrow (Mon). Would I be correct presuming you didn't test whether the existing step-g importer still works?
If not, no big deal but we'll have to make sure. Still, looks fantastic.
I did not test whether the existing importer still works...I know that the code compiles under the environment I describe in the patch notes.
I'll try to be on irc tomorrow if you need me while you're testing things =)
This patch has been applied as r45618. Testing was performed on a couple step files using our step-g importer, all of which worked equivalently. Thanks!
Also worth noting, performed a quick time comparison before and after applying the patch. There was no discernible difference observed.