Menu
▾
▴
#447 rvdiffto parameter implementation
No revisions diff text loading function is implemented in the framework. Here is one:
Changelog:
Modified site.loadrevisions() method to support rvdiffto parameter.
Added a Page.Revision.Diff class for storing the diff text and revto id.
Modified api.update_page() to save the new diff information.
A method from Page.py is still missing to get diffs just like you get a revision now. But you can get the diff text from page._revision[id].diff.text directly for now.
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
rvdiffto parameter implementation
Sorry for the slow slow slow sloooow response.
I think diffs are a useful thing to have, but I'm not quite sure what the goal here is - what is the advantage of using rvdiffto instead of getting both revisions and comparing them with a python diff function?
I can see the use case for, for instance, an antivandalism bot, but I'm not quite sure how you would use it with this.
Then on the implementation - I can imagine it makes sense to store diffs for a certain revision, but I'd expect, for instance, a dict with revid's such that
page, revid=10001
diffs = {10000: <diff object between 10000 and 10001>, 9000: <diff object between 9000 and 10001>}, and storing e.g. revision.prev = 10000.
housekeeper's note:the patch does not apply cleanly to r10035