Menu

#236 black screen bug + refactoring

closed
nobody
None
5
2008-01-06
2007-12-28
Jordi Polo
No

Found the black screen bug. (a bad call to SetFog)
The following patch solves that bug and also make some code refactoring.
A new object OgreCreator.
The logic is that complex entities creation goes there. Part of the effort to move rendering tasks to the rendering directory (CreatePlane).
Also OgreAdaptor had become a miscellaneous object. This new object takes care a group of related functions.

Discussion

  • Jordi Polo

    Jordi Polo - 2007-12-28

    correct patch

     
  • Jordi Polo

    Jordi Polo - 2007-12-28

    Logged In: YES
    user_id=1514795
    Originator: YES

    File Added: patch_ogrecreator

     
  • Jordi Polo

    Jordi Polo - 2007-12-28

    Logged In: YES
    user_id=1514795
    Originator: YES

    Ok, I didn't understand how setFog worked, now I do.
    I suggest to simply delete that line.
    I guess the fog was set in any case for performance reasons. For this same effect, it is far better to play with the farclip of the camera.

    Anyway this patch is a worthy refactoring.

     
  • Jordi Polo

    Jordi Polo - 2008-01-06

    Logged In: YES
    user_id=1514795
    Originator: YES

    Already submitted to SVN

     
  • Jordi Polo

    Jordi Polo - 2008-01-06
    • status: open --> closed
     

Log in to post a comment.