Menu

#173 Empty comment block at beginning of line

closed-fixed
3
2011-03-12
2011-03-09
No

With comments spanning multiple lines, an extraneous <span class="comment"></span> is left at the beginning of the line following the comment block.

This is caused by the \n of every line being changed to </span>\n<span class="comment">.

Though harmless, it is inelegant. It can easily be removed, contributing to transmit less data.

Proposed patch:

In Lang, sub processcomment

!-87 110304 (after line 87, insert:)
! $$frag =~ s#<span class=\"comment\"></span>$## ; #remove excess marking
-------------------- end of patch ----------------------

Discussion

  • Andre-Littoz

    Andre-Littoz - 2011-03-09
    • priority: 5 --> 3
     
  • Andre-Littoz

    Andre-Littoz - 2011-03-09
    • status: open --> open-works-for-me
     
  • Andre-Littoz

    Andre-Littoz - 2011-03-11
    • assigned_to: nobody --> ajlittoz
     
  • Andre-Littoz

    Andre-Littoz - 2011-03-12
    • status: open-works-for-me --> closed-fixed
     
  • Andre-Littoz

    Andre-Littoz - 2011-03-12

    This has now been fixed in CVS.

    If you can install the new version and check that it solves your
    problem, then it would be very useful.

    Thanks for reporting this defect and helping to make LXR better.

     
  • Andre-Littoz

    Andre-Littoz - 2011-03-12

    Incorporated fix

     

Log in to post a comment.