Menu

#334 fix fork() crash on Vista x64

Patch_committed
closed-accepted
msys (22)
2008-07-11
2007-06-02
No

MSYS programs crash when calling fork() on Vista 64. This patch was posted by Oscar Bonilla and modified slightly by me to fix a problem with exceve(). It fixes the crash by filling out a size field in a structure passed to child processes.

Discussion

  • James Darpinian

    James Darpinian - 2007-06-02

    patch for files in msys\rt\src\winsup\cygwin

     
  • Earnie Boyd

    Earnie Boyd - 2007-06-02
    • milestone: 684957 --> 684956
    • assigned_to: earnie --> nobody
     
  • Earnie Boyd

    Earnie Boyd - 2007-06-02

    Logged In: YES
    user_id=15438
    Originator: NO

    You submit patches for reviewing. Once reviewed they can be mared for ready to be committed.

     
  • Keith Marshall

    Keith Marshall - 2007-06-04
    • assigned_to: nobody --> cstrauss
     
  • Keith Marshall

    Keith Marshall - 2007-06-04

    Logged In: YES
    user_id=823908
    Originator: NO

    This is effectively a duplicate of bug #1674783, which also has a similar patch attached. There are differences, however, particularly in the computation of the size field to be filled in for Vista. Given the level of discussion which has followed the #1674783 bug, I'd tend to favour its associated patch. In any case, the two should be rationalised into a single agreed solution.

    I would point out that neither patch could be considered `ready to commit', since neither is accompanied by a properly formatted ChangeLog; this needs to be provided, before any patch can be committed.

     
  • Cesar Strauss

    Cesar Strauss - 2008-07-11

    Logged In: YES
    user_id=1369729
    Originator: NO

    A variant of this patch was accepted into CVS and is included in a recent snapshot.

    Thanks,
    Cesar

     
  • Cesar Strauss

    Cesar Strauss - 2008-07-11
    • milestone: 684956 --> Patch_committed
    • status: open --> closed-accepted