ADempiere ERP Business Suite / Bugs / #2042 AccessSqlParser is not parsing well ON keyword

#2042 AccessSqlParser is not parsing well ON keyword

Milestone: Core

Status: closed-fixed

Owner: Teo Sarca

Labels: None

Priority: 9

Updated: 2009-09-04

Created: 2009-08-19

Creator: Teo Sarca

Private: No

Following query is generating OutOfMemoryException:

SELECT 1
FROM M_Product p
INNER JOIN M_Product_Category pc on (pc.M_Product_Category_ID=p.M_Product_Category_ID)
LEFT OUTER JOIN M_Product_PO mpo ON (mpo.M_Product_ID=p.M_Product_ID)

(please note de lower case "on")

Best regards,
Teo Sarca - www.arhipac.ro

Discussion

Teo Sarca - 2009-08-19

status: open --> pending-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Sarca - 2009-08-19

Revision: 9963
http://adempiere.svn.sourceforge.net/adempiere/?rev=9963&view=rev
Author: teo_sarca
Date: 2009-08-19 09:41:42 +0000 (Wed, 19 Aug 2009)

Log Message:
-----------
BF [ 2840157 ] AccessSqlParser is not parsing well ON keyword
https://sourceforge.net/tracker/?func=detail&aid=2840157&group_id=176962&atid=879332

Modified Paths:
--------------
trunk/base/src/org/compiere/model/AccessSqlParser.java
trunk/base/src/org/compiere/model/AccessSqlParserTest.java

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carlos Ruiz - 2009-08-19

Thanks Teo for fixing this.

One of the "practices" imposed by Compiere I don't like is the need of writing sql keywords uppercase, if you look the rest of AccessSQLParser it's assuming lots of keywords to be uppercase, and parser can fail if you write "select" or "from" (and I can see lots of the new code with lowercase sql)

I'm wondering if a permanent solution can be simply to put all the sql sentence uppercase for parser, wdyt?

Regards,

Carlos Ruiz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Sarca - 2009-08-20

status: pending-fixed --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Sarca - 2009-08-20

Hi Carlos,

I think will solve this issue efficient.
The only downside will be with case sensitive table names and/or case sensitive databases, but i think is not our case ;)

WDYT?

Best regards,
Teo Sarca, www.arhipac.ro

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Sarca - 2009-08-20

status: open-fixed --> pending-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

SourceForge Robot - 2009-09-04

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

SourceForge Robot - 2009-09-04

status: pending-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.