Menu

#1617 Voiding completed order does not update order tax

z_don't_use_3.5.2a
closed-invalid
Order (PO) (22)
5
2009-07-18
2008-12-04
No

Voiding a completed order sets the quantities and line totals to zero, but fails to reset the order tax.

This results in an order total of zero but a positive order grand total equal to the original tax amount (for a non tax-inclusive order).

The issue seems to be caused by MOrderline.updateHeaderTax():

private boolean updateHeaderTax()
{
// Recalculate Tax for this Tax
if (!getParent().isProcessed())
if (!updateOrderTax(false))
return false;
...

As the (completed) order being voided is flagged as processed this prevents the tax from being updated.

Teo: Your name's on the updateOrderTax function, do you have any suggestions for fixing this? I assume we wouldn't want to just remove the check...

Regards,

Paul

Discussion

  • Carlos Ruiz

    Carlos Ruiz - 2008-12-04

    Good catch Paul,

    I think the validation is ok in MOrderLine.beforeSave - maybe adding the logic to zero-it the taxes in voidIt method.

    Regards,

    Carlos Ruiz

     
  • Anca Bradau

    Anca Bradau - 2009-02-11

    Issue is not resolved!

    Best Regards,
    Anca Bradau
    www.arhipac.ro

     
  • Paul Bowden (Adaxa)

    • status: open --> pending-invalid
     
  • SourceForge Robot

    • status: pending-invalid --> closed-invalid
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Log in to post a comment.