Menu
▾
▴
#730 (ok 4.0) Contest-4 : feature request ID: 2046140
closed-fixed
1
2013-05-09
2012-03-17
No
Because of using <input type="text"> for VARCHAR fields it's not able to insert or edit large values to these fields because the maximum lenght of the textfield values are limited by HTML and/or the browsers.
It uses <textarea> for larger VARCHAR (<255) in this patch.
Discussion
Thanks for your patch. I cannot accept it because it has the effect of changing any VARCHAR following the one that is larger than 255, to textareas.
I have updated the patch file and it has been attached. in this patch uses the <textarea> for larger VARCHAR
Thilina,
the second patch assumes that the user is still using the default value for $cfg['CharEditing'], which is not always the case. Rejected.
updated patch
I have updated the patch
Please do not delete your attached files; it's better to give different names like contest-4-attempt-3.diff.
The third patch has the same problem as the second patch. Rejected.
Thanks Marc,
So can you tell me the meaning of "assumes that the user is still using the default value for $cfg['CharEditing']" I couldn't get it.
In libraries/config.default.php, the value of $cfg['CharEditing'] is 'input'. However, a user can set a different value for this directive, for example in his config.inc.php.
A good patch has to take this into account.
Marc,
Did you mean config.sample.inc.php file? I couldn't find config.inc.php file.
attempt 4
Thilina,
at this point, you really need to read in Documentation.html (which is included with phpMyAdmin), the Installation section to learn about config.inc.php.
Thanks Marc . I'll read.
And what about my attempt-4 patch ?
Patch #4 does not apply to the current master branch.
That means, Still there is a problem with the patch? need improvement?