#730 (ok 4.0) Contest-4 : feature request ID: 2046140

closed-fixed
1
2013-05-09
2012-03-17
No

Because of using <input type="text"> for VARCHAR fields it's not able to insert or edit large values to these fields because the maximum lenght of the textfield values are limited by HTML and/or the browsers.
It uses <textarea> for larger VARCHAR (<255) in this patch.

Discussion

1 2 > >> (Page 1 of 2)
  • Marc Delisle

    Marc Delisle - 2012-03-17
    • summary: (ok 4.0) Context-4 : feature request ID: 2046140 --> Context-4 : feature request ID: 2046140
     
  • Marc Delisle

    Marc Delisle - 2012-03-17
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2012-03-17
    • summary: Context-4 : feature request ID: 2046140 --> Contest-4 : feature request ID: 2046140
     
  • Marc Delisle

    Marc Delisle - 2012-03-17
    • status: open --> pending-rejected
     
  • Marc Delisle

    Marc Delisle - 2012-03-17

    Thanks for your patch. I cannot accept it because it has the effect of changing any VARCHAR following the one that is larger than 255, to textareas.

     
  • Thilina Abeyrathna

    • status: pending-rejected --> open-rejected
     
  • Thilina Abeyrathna

    I have updated the patch file and it has been attached. in this patch uses the <textarea> for larger VARCHAR

     
  • Marc Delisle

    Marc Delisle - 2012-03-31
    • status: open-rejected --> open
     
  • Marc Delisle

    Marc Delisle - 2012-03-31
    • status: open --> pending-rejected
     
  • Marc Delisle

    Marc Delisle - 2012-03-31

    Thilina,
    the second patch assumes that the user is still using the default value for $cfg['CharEditing'], which is not always the case. Rejected.

     
  • Thilina Abeyrathna

    I have updated the patch

     
  • Marc Delisle

    Marc Delisle - 2012-04-01
    • status: pending-rejected --> open-rejected
     
  • Marc Delisle

    Marc Delisle - 2012-04-01
    • status: open-rejected --> open
     
  • Marc Delisle

    Marc Delisle - 2012-04-01
    • status: open --> pending-rejected
     
  • Marc Delisle

    Marc Delisle - 2012-04-01

    Please do not delete your attached files; it's better to give different names like contest-4-attempt-3.diff.

    The third patch has the same problem as the second patch. Rejected.

     
  • Thilina Abeyrathna

    Thanks Marc,
    So can you tell me the meaning of "assumes that the user is still using the default value for $cfg['CharEditing']" I couldn't get it.

     
  • Marc Delisle

    Marc Delisle - 2012-04-01

    In libraries/config.default.php, the value of $cfg['CharEditing'] is 'input'. However, a user can set a different value for this directive, for example in his config.inc.php.

    A good patch has to take this into account.

     
  • Thilina Abeyrathna

    Marc,
    Did you mean config.sample.inc.php file? I couldn't find config.inc.php file.

     
  • Marc Delisle

    Marc Delisle - 2012-04-01

    Thilina,
    at this point, you really need to read in Documentation.html (which is included with phpMyAdmin), the Installation section to learn about config.inc.php.

     
  • Thilina Abeyrathna

    Thanks Marc . I'll read.

     
  • Thilina Abeyrathna

    And what about my attempt-4 patch ?

     
  • Marc Delisle

    Marc Delisle - 2012-04-02

    Patch #4 does not apply to the current master branch.

     
  • Thilina Abeyrathna

    That means, Still there is a problem with the patch? need improvement?

     
1 2 > >> (Page 1 of 2)

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks