Exception incorrectly handled: break instead of exit?

Brought to you by: gerundt, nicocha, oheil

#381 Exception incorrectly handled: break instead of exit?

Status: closed-fixed

Owner: nobody

Labels: Other (69)

Priority: 5

Updated: 2010-03-01

Created: 2010-02-28

Creator: openfan

Private: No

At line 68 of common.php there is a break statement that doesn't work here, because it is within an if statement, and not within a control structure. According to the PHP manual (http://www.php.net/manual/en/control-structures.break.php): "break ends execution of the current for, foreach, while, do-while or switch structure."

I guess this should be an exit statement, like in the other code blocks that handle exceptions?

NOCC 1.8.2

Discussion

Tim Gerundt - 2010-03-01

Good catch!

Committed to SVN (In Revision 2127)...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Gerundt - 2010-03-01

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Exception incorrectly handled: break instead of exit?

Group

Searches

Help

#381 Exception incorrectly handled: break instead of exit?

Discussion