#416 (ok 3.1) Cannot restore to "none" at first reques
1. select a table, select export
2. SQL compatibility mode: ANSI, submit, you get all fields quoted by double quote so ANSI is working. it's now ANSI mode
3. select NONE, click submit, i got "......) TYPE=InnoDB;"
4. select NONE, click submit again, i got ".....) ENGINE=InnoDB DEFAULT CHARSET=utf8;"
the first "NONE" submit is incorrectly handled
Index: sql.php
--- sql.php (revision 11534)
+++ sql.php (working copy)
@@ -189,8 +189,13 @@
global $cfg;
global $mysql_charset_map;
- if (isset($GLOBALS['sql_compatibility']) && $GLOBALS['sql_compatibility'] != 'NONE') {
- PMA_DBI_try_query('SET SQL_MODE="' . $GLOBALS['sql_compatibility'] . '"');
+ if (isset($GLOBALS['sql_compatibility'])) {
+ if ($GLOBALS['sql_compatibility'] == 'NONE') {
+ PMA_DBI_query('SET SQL_MODE=""');
+ }
+ else {
+ PMA_DBI_try_query('SET SQL_MODE="' . $GLOBALS['sql_compatibility'] . '"');
+ }
}
$head = PMA_exportComment('phpMyAdmin SQL Dump')
. PMA_exportComment('version ' . PMA_VERSION)
Discussion
Logged In: YES
user_id=210714
Originator: NO
Moved to patches.
Logged In: YES
user_id=192186
Originator: NO
Merged in SVN, thanks.