#416 (ok 3.1) Cannot restore to "none" at first reques

closed-fixed
1
2008-11-28
2008-09-02
Xuefer
No

1. select a table, select export
2. SQL compatibility mode: ANSI, submit, you get all fields quoted by double quote so ANSI is working. it's now ANSI mode
3. select NONE, click submit, i got "......) TYPE=InnoDB;"
4. select NONE, click submit again, i got ".....) ENGINE=InnoDB DEFAULT CHARSET=utf8;"
the first "NONE" submit is incorrectly handled

Index: sql.php

--- sql.php (revision 11534)
+++ sql.php (working copy)
@@ -189,8 +189,13 @@
global $cfg;
global $mysql_charset_map;

- if (isset($GLOBALS['sql_compatibility']) && $GLOBALS['sql_compatibility'] != 'NONE') {
- PMA_DBI_try_query('SET SQL_MODE="' . $GLOBALS['sql_compatibility'] . '"');
+ if (isset($GLOBALS['sql_compatibility'])) {
+ if ($GLOBALS['sql_compatibility'] == 'NONE') {
+ PMA_DBI_query('SET SQL_MODE=""');
+ }
+ else {
+ PMA_DBI_try_query('SET SQL_MODE="' . $GLOBALS['sql_compatibility'] . '"');
+ }
}
$head = PMA_exportComment('phpMyAdmin SQL Dump')
. PMA_exportComment('version ' . PMA_VERSION)

Discussion

  • Marc Delisle

    Marc Delisle - 2008-09-02
    • labels: 546627 --> Data Export
    • summary: [patch] fix: cannot restore to "none" at first request --> Cannot restore to "none" at first request
    • milestone: 284140 -->
     
  • Marc Delisle

    Marc Delisle - 2008-09-02

    Logged In: YES
    user_id=210714
    Originator: NO

    Moved to patches.

     
  • Michal Čihař

    Michal Čihař - 2008-09-03
    • assigned_to: nobody --> nijel
     
  • Michal Čihař

    Michal Čihař - 2008-09-03

    Logged In: YES
    user_id=192186
    Originator: NO

    Merged in SVN, thanks.

     
  • Michal Čihař

    Michal Čihař - 2008-09-03
    • status: open --> open-fixed
     
  • Michal Čihař

    Michal Čihař - 2008-09-03
    • priority: 5 --> 1
    • summary: Cannot restore to "none" at first request --> (ok 3.1) Cannot restore to "none" at first reques
     
  • Marc Delisle

    Marc Delisle - 2008-11-28
    • status: open-fixed --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks