Menu
▾
▴
#128 message body word wrap
closed-fixed
None
5
2008-03-12
2008-03-07
No
(10)-[radical-tobi@shell]->diff functions.php functions_mod.php
618,620c618
< $body = nl2br($body);
< if (function_exists('wordwrap'))
< $body = wordwrap($body, 80, "\n");
---
>
621a620,625
> $body = nl2br($body);
>
> if (function_exists('wordwrap')) {
> $body = wordwrap($body, 80, "\n");
> }
>
Logged In: YES
user_id=529507
Originator: NO
Could you please explain the goal of this patch and attach the diff file itself ?
broken wordwrap
Logged In: YES
user_id=75246
Originator: YES
The wordwrap does not work because of the location of the function call for wordwrap ...
File Added: nocc-broken_wordwrap.png
Logged In: YES
user_id=75246
Originator: YES
File Added: nocc_wordwrap.diff
Logged In: YES
user_id=529507
Originator: NO
I'm sorry, but none of my patching tools can use your diff file (command line “patch” tool and Eclipse one). Could your attach either an unified patch file or the entire modified file or function ? Thanks again.
Logged In: YES
user_id=652377
Originator: NO
Mhh, the only difference I see is the added "{" and "}". Technically it should work without "{ ... }", since it is only 1 line inside the if block. It works for you only if you add "{" and "}"?
Btw: Cool NOCC theme at the screenshot!
Greetings from Germany,
Tim
Logged In: YES
user_id=75246
Originator: YES
Sorry, I re-submitting a valid patch.
File Added: nocc-1_5-wordwrap.patch
patch
Logged In: YES
user_id=529507
Originator: NO
Fixed in CVS.
It'll be included in next release.
But you can download daily snapshots at :
http://nocc.sourceforge.net/download/
Thanks for the patch.