Menu

#99 Optimize login box

closed-fixed
None
5
2007-01-30
2007-01-08
Tim Gerundt
No

This patch optimize the "login box":

1. Simplify and group CSS rules
* Use "loginBox" id instead "loginContent" class
* "f", "loginForm" and "loginTitle" classes are unnecessary

2. Use more structured HTML
* Use "<h2>" for login title
* Remove unnecessary "<td colspan="3">&nbsp;</td>" and use "padding" instead

3. Better scaling and zooming (specially with Firefox)
* Use "27em" for login box width
* Use no fixed px size for login title

Tim

P.S.: I know you are not a big fan from changes in the theme CSS files, but I think you can't prevent them always. The current HTML and CSS code is outdated and complicated. And it is no fun to write a own theme. :-(

So I hope you accept the patch as first step to a better HTML/CSS code.

Discussion

  • Tim Gerundt

    Tim Gerundt - 2007-01-08

    original and altered files

     
  • Tim Gerundt

    Tim Gerundt - 2007-01-08

    Logged In: YES
    user_id=652377
    Originator: YES

    File Added: optimize_login_box.diff

     
  • Tim Gerundt

    Tim Gerundt - 2007-01-08

    patch file

     
  • Anonymous

    Anonymous - 2007-01-30

    Logged In: YES
    user_id=529507
    Originator: NO

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the patch.

     
  • Anonymous

    Anonymous - 2007-01-30
    • assigned_to: nobody --> goddess_skuld
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB