Menu ▾ ▴

#94 login_with_domain not checked correctly

closed-fixed
None
5
2006-11-06
2006-11-04
Tim Gerundt
No

My friend "Sebastian Marotzki" has found a bug:
If "$conf->domains[$i]->login_with_domain" is set
with "0", NOCC anyway add the domain to the login.

Problem is a missing "&& ($conf->domains[$domainnum]-
>login_with_domain == 1)" at line 212 in
file "common.php":

-------------------------8<-------------------------
--- C:/Temp/nocc/common.php.org Fri Oct 20 21:57:55
2006
+++ C:/Temp/nocc/common.php Fri Nov 03 22:59:05
2006
@@ -209,7 +209,7 @@
}

// Do we provide the domain with the login?
- if(isset($conf->domains[$domainnum]-
>login_with_domain)){
+ if(isset($conf->domains[$domainnum]-
>login_with_domain) && ($conf->domains[$domainnum]-
>login_with_domain == 1)){
if (isset($conf->domains[$domainnum]-
>login_with_domain_character) && $conf->domains
[$domainnum]->login_with_domain_character != '') {
$_SESSION['nocc_login'] .= $conf->domains
[$domainnum]->login_with_domain_character . $_SESSION
['nocc_domain'];
} else {
------------------------->8-------------------------

Greetings,
Tim

Discussion

  • Tim Gerundt

    Tim Gerundt - 2006-11-04

    original and altered file

     
  • Anonymous

    Anonymous - 2006-11-06

    Logged In: YES
    user_id=529507

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the patch.

     
  • Anonymous

    Anonymous - 2006-11-06
    • assigned_to: nobody --> goddess_skuld
    • status: open --> closed-fixed
     

Log in to post a comment.