Menu ▾ ▴

#335 Download mail, illegal characters in filename on save

Reproducible
closed-fixed
Other (69)
5
2006-10-19
2006-10-18
openfan
No

If in MSIE you download a mail that has (for example) a
question mark at the end of the subjectline, you can
not save the mail just by accepting the default target
filename (because it contains an ? then) and you have
to change it before save. Firefox does not have this
problem, it seems to strip trouble characters itself.

It is probably the best to strip characters that should
not appear in filename suggested for save. The safe
range of characters in a filename for various OS's is
probably only a-zA-Z0-9_-

You could also have a problem if subject is too long?
(maximum filename length) or probably the subject is
not a good basis voor the default name of the saved file?
(Althuog, I can not easily think of another user
friendly solution)

Environment:
NOCC 1.3-dev CVS build 2006-10-17
Windows XP Pro SP2
MSIE 6

Discussion

  • Anonymous

    Anonymous - 2006-10-19
    • assigned_to: nobody --> goddess_skuld
     
  • Tim Gerundt

    Tim Gerundt - 2006-10-19

    Logged In: YES
    user_id=652377

    SquirrelMail use this code, to avoid illegal characters:
    $filename = ereg_replace('[\\/:\*\?"<>|;]', '_',
    str_replace('&nbsp;', ' ', $filename));

    Greetings,
    Tim

     
  • Anonymous

    Anonymous - 2006-10-19

    Logged In: YES
    user_id=529507

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the bug report.

     
  • Anonymous

    Anonymous - 2006-10-19
    • status: open --> closed-fixed
     

Log in to post a comment.