Menu

#156 cmake build options are broken

v3.0.2
closed-invalid
nobody
None
5
2017-07-24
2017-07-23
Yuri
No

cmake enables lash despite -DLashEnabe:BOOL=OFF
It also adds -ljack despite saying that JACK is "NOT enabled".

Every build option should have its own "option" statement. cmake scripts should go strictly by that.

It should look like this:
option (USE_JACK "Support Jack sound system" ON)
option (USE_LASH "LASH audio support" ON)

Each option should have 3 states: ON - forces the use, OFF - disables it, AUTO - uses it when installed.

Discussion

  • Yuri

    Yuri - 2017-07-24

    Please close this. There was a typo in the package that caused this.

     
  • Mark McCurry

    Mark McCurry - 2017-07-24
    • status: open --> closed-invalid
     
  • Mark McCurry

    Mark McCurry - 2017-07-24

    Closed based upon poster's request.

     

Log in to post a comment.

MongoDB Logo MongoDB