Menu
▾
▴
zookeeper-developer — Mailing list to discuss development of zookeeper
You can subscribe to this list here.
| 2007 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(37) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2008 |
Jan
(27) |
Feb
(34) |
Mar
(30) |
Apr
(151) |
May
(184) |
Jun
(55) |
Jul
(2) |
Aug
(6) |
Sep
|
Oct
(1) |
Nov
|
Dec
|
|
From: SourceForge.net <no...@so...> - 2008-05-06 17:15:25
|
Patches item #1958361, was opened at 2008-05-05 17:00 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1958361&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: fpj (fpj) Assigned to: Nobody/Anonymous (nobody) Summary: Patch to fix NPE upon access to watcher Initial Comment: This patch is related to bug reports 1956937 and 1941629. There is a race condition in the ZooKeeper constructor. In the current version, the constructor creates ClientCnxn before it sets the watcher attribute, which causes a NullPoiterException to be thrown. This patch just inverts the order of instantiating ClientCnxn and assigning a value to the watcher attribute. -Flavio ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-06 10:15 Message: Logged In: YES user_id=12853 Originator: NO Moving to patches rather than bug list. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1958361&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-06 06:23:32
|
Patches item #1951806, was opened at 2008-04-25 17:10 Message generated for change (Comment added) made by mahadevkonar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1951806&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ted Dunning (tedunning) Assigned to: Nobody/Anonymous (nobody) Summary: Sample startup script Initial Comment: This may be useful as a temporary script. Eventually there are several things that should be improved: a) the log rotation hack should go away when real logging get implemented b) the kill hack should go away when there is a good way to kill the process. In the meantime, this may be handy to people at least as a starting point. ---------------------------------------------------------------------- >Comment By: Mahadev Konar (mahadevkonar) Date: 2008-05-06 06:22 Message: Logged In: YES user_id=1926680 Originator: NO nice scripts ben... i was supposed to do this ... in http://sourceforge.net/tracker/index.php?func=detail&aid=1958195&group_id=209147&atid=1008544 but looks like this is going to be sufficient. thanks for doing my work :)... (as always) i was surprised to see that readlink is installed by default on cygwin as well. So this should be good enough for cygwin as well. Also, maybe we can add zookeeper.root.logger as a system property which the scripts can set so the lo4j.properties looks like root.Logger = ${zookeeper.root.logger} and make it configurable via the script -Dzookeeper.root.logger=${ZOOKEEPER_ROOT_LOGGER:-INFO,console}" ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-05-05 23:08 Message: Logged In: YES user_id=972206 Originator: YES Much nicer. Thanks. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-05 21:12 Message: Logged In: YES user_id=154690 Originator: NO Okay, I've enhanced your patch a lot Ted. It assumes an installation directory structure of bin, lib, and conf as siblings. It finds the directory based on the realpath of the script being run. (This is how things like firefox and java are setup on Linux usually.) zkServer.sh is designed to be run from init.d zkCleanup.sh is designed to run from cron zkCli.sh is designed to run from a shell. File Added: scripts.patch ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-05-01 22:58 Message: Logged In: YES user_id=972206 Originator: YES Ben, Your comments are good, but this is a place-holder. I would hope that you guys would have something much better soon. a) regarding logging, the logging system should do log rotation and cleanup. Until logging is available in a released version (and I build a log configuration file), I will just do the rotation in this script. It is a placeholder and work-around, after all. b) regarding dirname, please change anything like that you like. It is a good idea. c) regarding zoo.cfg in /etc, I can't comment if that really is a good place or not. If you would like to standardize on that, fine. Perhaps, I should put in a bit of baby logic to look first in /etc/zoo.cfg and then in $ZOO/zoo.cfg. d) regarding zoo.cfg instead of ZOO/zoo.cfg, that is just an error. Thanks for catching it. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 22:00 Message: Logged In: YES user_id=154690 Originator: NO Thanx Ted. I think ZOO should be set using dirname $0 Log cleanup shouldn't really be done in the startup scripts right? Finally, I think we should get the config from /etc/zookeeper/zoo.cfg right? In your script you use $ZOO/zoo.cfg and zoo.cfg, but both seem wrong (with the latter more wrong :) ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 21:20 Message: Logged In: YES user_id=154690 Originator: NO Deleted old version so it was clear what we were reviewing. ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-30 17:47 Message: Logged In: YES user_id=972206 Originator: YES Here is an updated script that uses the kill command. I am quite dubious of the wisdom of allowing arbitrary processes anywhere on the net to kill a zookeeper. It definitely means that zookeepers cannot be exposed at all to anything except a very friendly environment. File Added: zookeeper.sh ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-29 23:42 Message: Logged In: YES user_id=972206 Originator: YES The kill hack is interesting. Good thing to know about. Kind of a dangerous feature, though. It also requires that I know something about the config or write something clever in the script that turns the config file into the telnet or nc command. The logs I am talking about are the accumulation of what currently comes out of standard output, not the transactional logs. I think that there is an enhancement coming that will use log4J. That would be vastly better than my hack of putting standard out to a file. ---------------------------------------------------------------------- Comment By: Andrew Kornev (akornev) Date: 2008-04-29 22:34 Message: Logged In: YES user_id=1926652 Originator: NO A better way to kill a server to send a kill command to the server's client port (the clientPort parameter in zoo.cfg), for example: echo kill|nc localhost 1234 ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-04-25 18:52 Message: Logged In: YES user_id=12853 Originator: NO Ted, be aware that there is also the following to be managed. The "log files" reference are transacitonal log files - not logging log files. "The ZooKeeper server creates snapshot and log files, but never deletes them. The retention policy of the data and log files is implemented outside of the ZooKeeper server. The server itself only needs the latest complete fuzzy snapshot and the log files from the start of that snapshot. The PurgeTxnLog utility implements a simple retention policy that administrators can use." http://zookeeper.wiki.sourceforge.net/ZooKeeperDataFormat ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1951806&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-06 00:00:36
|
Bugs item #1958361, was opened at 2008-05-06 02:00 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958361&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: fpj (fpj) Assigned to: Nobody/Anonymous (nobody) Summary: Patch to fix NPE upon access to watcher Initial Comment: This patch is related to bug reports 1956937 and 1941629. There is a race condition in the ZooKeeper constructor. In the current version, the constructor creates ClientCnxn before it sets the watcher attribute, which causes a NullPoiterException to be thrown. This patch just inverts the order of instantiating ClientCnxn and assigning a value to the watcher attribute. -Flavio ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958361&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 23:44:37
|
Bugs item #1941629, was opened at 2008-04-14 02:02 Message generated for change (Comment added) made by fpj You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1941629&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: fpj (fpj) Summary: NPE on startup Initial Comment: I got this in my logs just now: 4/13/08 4:58:28 PM PDT [ClientCnxn.java@623][13]: Trying to connect to localhost/127.0.0.1:8181 4/13/08 4:58:28 PM PDT [ClientCnxn.java@544][13]: Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:60651 remote=localhost/127.0.0.1:8181] Exception in thread "EventThread" java.lang.NullPointerException at com.yahoo.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:253) It didn't seem to affect subsequent operation, but it probably shouldn't be happening (or should be caught). ---------------------------------------------------------------------- >Comment By: fpj (fpj) Date: 2008-05-06 01:44 Message: Logged In: YES user_id=1926444 Originator: NO Patrick, you're right, looks like the same as 1956937. I'll work on the patch. -Flavio ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 01:02 Message: Logged In: YES user_id=12853 Originator: NO Flavio can you look at this, looks like the same as 1956937. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1941629&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 23:08:18
|
Patches item #1951806, was opened at 2008-04-25 10:10 Message generated for change (Comment added) made by tedunning You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1951806&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ted Dunning (tedunning) Assigned to: Nobody/Anonymous (nobody) Summary: Sample startup script Initial Comment: This may be useful as a temporary script. Eventually there are several things that should be improved: a) the log rotation hack should go away when real logging get implemented b) the kill hack should go away when there is a good way to kill the process. In the meantime, this may be handy to people at least as a starting point. ---------------------------------------------------------------------- >Comment By: Ted Dunning (tedunning) Date: 2008-05-05 16:08 Message: Logged In: YES user_id=972206 Originator: YES Much nicer. Thanks. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-05 14:12 Message: Logged In: YES user_id=154690 Originator: NO Okay, I've enhanced your patch a lot Ted. It assumes an installation directory structure of bin, lib, and conf as siblings. It finds the directory based on the realpath of the script being run. (This is how things like firefox and java are setup on Linux usually.) zkServer.sh is designed to be run from init.d zkCleanup.sh is designed to run from cron zkCli.sh is designed to run from a shell. File Added: scripts.patch ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-05-01 15:58 Message: Logged In: YES user_id=972206 Originator: YES Ben, Your comments are good, but this is a place-holder. I would hope that you guys would have something much better soon. a) regarding logging, the logging system should do log rotation and cleanup. Until logging is available in a released version (and I build a log configuration file), I will just do the rotation in this script. It is a placeholder and work-around, after all. b) regarding dirname, please change anything like that you like. It is a good idea. c) regarding zoo.cfg in /etc, I can't comment if that really is a good place or not. If you would like to standardize on that, fine. Perhaps, I should put in a bit of baby logic to look first in /etc/zoo.cfg and then in $ZOO/zoo.cfg. d) regarding zoo.cfg instead of ZOO/zoo.cfg, that is just an error. Thanks for catching it. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 15:00 Message: Logged In: YES user_id=154690 Originator: NO Thanx Ted. I think ZOO should be set using dirname $0 Log cleanup shouldn't really be done in the startup scripts right? Finally, I think we should get the config from /etc/zookeeper/zoo.cfg right? In your script you use $ZOO/zoo.cfg and zoo.cfg, but both seem wrong (with the latter more wrong :) ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 14:20 Message: Logged In: YES user_id=154690 Originator: NO Deleted old version so it was clear what we were reviewing. ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-30 10:47 Message: Logged In: YES user_id=972206 Originator: YES Here is an updated script that uses the kill command. I am quite dubious of the wisdom of allowing arbitrary processes anywhere on the net to kill a zookeeper. It definitely means that zookeepers cannot be exposed at all to anything except a very friendly environment. File Added: zookeeper.sh ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-29 16:42 Message: Logged In: YES user_id=972206 Originator: YES The kill hack is interesting. Good thing to know about. Kind of a dangerous feature, though. It also requires that I know something about the config or write something clever in the script that turns the config file into the telnet or nc command. The logs I am talking about are the accumulation of what currently comes out of standard output, not the transactional logs. I think that there is an enhancement coming that will use log4J. That would be vastly better than my hack of putting standard out to a file. ---------------------------------------------------------------------- Comment By: Andrew Kornev (akornev) Date: 2008-04-29 15:34 Message: Logged In: YES user_id=1926652 Originator: NO A better way to kill a server to send a kill command to the server's client port (the clientPort parameter in zoo.cfg), for example: echo kill|nc localhost 1234 ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-04-25 11:52 Message: Logged In: YES user_id=12853 Originator: NO Ted, be aware that there is also the following to be managed. The "log files" reference are transacitonal log files - not logging log files. "The ZooKeeper server creates snapshot and log files, but never deletes them. The retention policy of the data and log files is implemented outside of the ZooKeeper server. The server itself only needs the latest complete fuzzy snapshot and the log files from the start of that snapshot. The PurgeTxnLog utility implements a simple retention policy that administrators can use." http://zookeeper.wiki.sourceforge.net/ZooKeeperDataFormat ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1951806&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 23:03:58
|
Bugs item #1948097, was opened at 2008-04-21 10:02 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1948097&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: c client Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Benjamin Reed (breed) >Assigned to: Benjamin Reed (breed) Summary: Connect timeouts not calculated properly Initial Comment: There should be a better connection between connect timeout, ping timeout, and session timeout. On the Java client it is sessionTimeout/hostsList.length. On the C client it's just the readTimeout. There is also an arbitrary delay when we find that all the hosts are down. We should come up with a good consistent story for the connect timeout. Since we leave sessionTimeout/3 ms for recovery from a down server, it seems most reasonable to have something like sessionTimeout/(3*hostsList.length). ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 16:04 Message: Logged In: YES user_id=12853 Originator: NO Assigning to Ben. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1948097&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 23:03:13
|
Bugs item #1946934, was opened at 2008-04-19 17:36 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1946934&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ted Dunning (tedunning) >Assigned to: Benjamin Reed (breed) Summary: NPE during normal operations Initial Comment: Somehow, I got my server to do this evil thing. I will try to figure out how to do this more consistently. 4/19/08 5:30:31 PM PDT [FinalRequestProcessor.java@220][8]: ****************************** 11944c2037100d8 256 fffffffffffffffe txn type = unknown getChildren n/a 4/19/08 5:30:31 PM PDT [FinalRequestProcessor.java@227][8]: ffffffff0 4/19/08 5:30:31 PM PDT [FinalRequestProcessor.java@228][8]: : java.lang.NullPointerException at java.util.concurrent.ConcurrentHashMap.hash(ConcurrentHashMap.java:157) at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:730) at com.yahoo.zookeeper.server.DataTree.getNode(DataTree.java:84) at com.yahoo.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:205) at com.yahoo.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:226) at com.yahoo.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113) 4/19/08 5:30:49 PM PDT [FinalRequestProcessor.java@220][8]: ****************************** 11944c2037100d8 257 fffffffffffffffe txn type = unknown exists n/a 4/19/08 5:30:49 PM PDT [FinalRequestProcessor.java@227][8]: ffffffff0 4/19/08 5:30:49 PM PDT [FinalRequestProcessor.java@228][8]: : java.lang.NullPointerException at com.yahoo.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:169) at com.yahoo.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:226) at com.yahoo.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113) ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 16:03 Message: Logged In: YES user_id=12853 Originator: NO Ben looks like you had a handle on this. Please submit a patch. ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-22 10:58 Message: Logged In: YES user_id=972206 Originator: YES Good thing then to have found it. My only problem is that by inspection, my code "can't" be sending the null. The usual software engineering definition of "can't" is obviously the one that I mean here. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-04-22 08:34 Message: Logged In: YES user_id=154690 Originator: NO I think your suspicion is correct. (I thought we were handling this.) It's actually a double bug! Both the server and client should check for a null path. ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-21 10:35 Message: Logged In: YES user_id=972206 Originator: YES java version "1.5.0_13" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_13-b05-241) Java HotSpot(TM) Client VM (build 1.5.0_13-121, mixed mode, sharing) Running on a mac under OSX 10.4 I think actually that this is actually a case of invalid arguments (from me) causing an obscure message rather than being caught. My suspicion is null path passed to create. I still owe you a test case. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-04-21 09:55 Message: Logged In: YES user_id=154690 Originator: NO Which version of Java are you using? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1946934&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 23:02:14
|
Bugs item #1941629, was opened at 2008-04-13 17:02 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1941629&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) >Assigned to: fpj (fpj) Summary: NPE on startup Initial Comment: I got this in my logs just now: 4/13/08 4:58:28 PM PDT [ClientCnxn.java@623][13]: Trying to connect to localhost/127.0.0.1:8181 4/13/08 4:58:28 PM PDT [ClientCnxn.java@544][13]: Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:60651 remote=localhost/127.0.0.1:8181] Exception in thread "EventThread" java.lang.NullPointerException at com.yahoo.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:253) It didn't seem to affect subsequent operation, but it probably shouldn't be happening (or should be caught). ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 16:02 Message: Logged In: YES user_id=12853 Originator: NO Flavio can you look at this, looks like the same as 1956937. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1941629&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 23:00:41
|
Bugs item #1948141, was opened at 2008-04-21 11:02 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1948141&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ted Dunning (tedunning) >Assigned to: Benjamin Reed (breed) Summary: KeeperException should be sub-classed Initial Comment: The current practice of setting an error code in KeeperException leads to error prone code that looks like this when only one kind of exception can be handled: void createOrUpdate(path, String data) { try { create(path, data) } catch (com.yahoo.zookeeper.KeeperException e) { if (e.getCode() == com.yahoo.zookeeper.KeeperException.Code.NodeExists) { update(path, data, -1) } else { throw e; } } } (ignore the lack of semi's... this is groovy) It would be much better to be able to write: void createOrUpdate(path, String data) { try { create(path, data) } catch (com.yahoo.zookeeper.NodeExistsException e) { update(path, data, -1) } } Where NodeExistsException extends KeeperException. The getCode method can be implemented as before so that old code will not notice the change. This change makes the exception handling much more Java friendly and less like C. I can create a patch if desired. ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 16:00 Message: Logged In: YES user_id=12853 Originator: NO Ben is working this out on patch 1949196 with Ted, assigning to Ben. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-04-22 13:51 Message: Logged In: YES user_id=154690 Originator: NO Fantastic work Ted! Do you mind submitting the patch to the patch tracker? That way we can tie it to a release. We are going to do one more release and then we will be putting in some API breaking patches. They will all be slight breaks, like the one here (changing a package, using an enum instead of int, etc...). My one other nit pick would be that in create() when you throw IllegalArgumentException() you put the error code number in the message. ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-22 11:46 Message: Logged In: YES user_id=972206 Originator: YES One thing that I should mention is that this patch fixes a minor bug in KeeperException where not all codes had an associated message. I added a message for NotEmpty ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-22 11:45 Message: Logged In: YES user_id=972206 Originator: YES Here is a patch. See the patch comments for details. File Added: 1948141.patch ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-04-22 08:30 Message: Logged In: YES user_id=154690 Originator: NO +1 Excellent suggestion! A patch would be great. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1948141&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 22:59:42
|
Bugs item #1958183, was opened at 2008-05-05 12:22 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958183&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: server Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) >Assigned to: Andrew Kornev (akornev) Summary: tar.gz does not build ; relies on revision number Initial Comment: If ant is run on code from .tar.gz distribution, the version-info task does not do what is supposed to do (generate a Info.java) because the revision number is empty. Additionally, the version-info task does not fail, it continues on its way, so the notification that something is wrong is not known until the build fails due to a missing Info.java file. Additionally, the VerGen class gives us the following error message: All version-related parameters must be invalid integers! I think that valid is the word you want here. :) ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 15:59 Message: Logged In: YES user_id=12853 Originator: NO Andrew mentioned that he's going to address this issue as part of the dist packaging change. Reassigning to him. ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-05 15:49 Message: Logged In: YES user_id=12853 Originator: NO I noticed the same issue when using GIT to manage local repositories of ZooKeeper. The build fails because it assumes that the code is contained within a svn repository. I will look into resolving this (specifically version gen being tied to svn, not the other distro issues). ---------------------------------------------------------------------- Comment By: Andrew Kornev (akornev) Date: 2008-05-05 12:38 Message: Logged In: YES user_id=1926652 Originator: NO Erik, thanks for catching that. I think we released the source tar a bit prematurely. While we're working on the fix, you're advised to either use the binary server tar or build from the SVN repository. Thanks! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958183&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 22:53:08
|
Bugs item #1951802, was opened at 2008-04-25 10:07 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1951802&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ted Dunning (tedunning) >Assigned to: Benjamin Reed (breed) Summary: Need a script for /etc/init.d Initial Comment: Running zookeeper as a service on a linux machine requires that there be a startup script. ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 15:53 Message: Logged In: YES user_id=12853 Originator: NO Ben is working on this with Ted for patch 1951806 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1951802&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 22:52:29
|
Bugs item #1958195, was opened at 2008-05-05 12:37 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) >Assigned to: Mahadev Konar (mahadevkonar) Summary: log4j is not present in zookeeper.jar Initial Comment: The attached patch includes log4j classes in the zookeeper.jar file. ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 15:52 Message: Logged In: YES user_id=12853 Originator: NO Assigned to Mahadev who is working on log4j/zk.jar changes (Ben is looking at the startup script in a separate patch 1951806 ) ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-05 15:42 Message: Logged In: YES user_id=12853 Originator: NO Thanks egh -- I further updated the page to reference the zookeeper logging page. The packaging issues are being worked on and should be addressed shortly. Regards. ---------------------------------------------------------------------- Comment By: Erik Hetzner (egh) Date: 2008-05-05 15:15 Message: Logged In: YES user_id=67250 Originator: YES Ok, I modified the wiki tutorial to remove information stating that the .jar file can be used as a standalone jar. You might also want to remove the .jar file distributed on sf.net, because it is impossible to run this file using -jar. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-05 14:20 Message: Logged In: YES user_id=154690 Originator: NO It is intentional. The fat jar proponent was out voted. We will be doing a new release shortly that distributes the java component as a tar.gz with scripts to start things up. ---------------------------------------------------------------------- Comment By: Erik Hetzner (egh) Date: 2008-05-05 12:44 Message: Logged In: YES user_id=67250 Originator: YES Perhaps this is intentional? It means that the binary server jar distributed via sf.net is not stand alone, however. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 22:49:36
|
Bugs item #1958183, was opened at 2008-05-05 12:22 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958183&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: server Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) >Assigned to: Patrick Hunt (phunt) Summary: tar.gz does not build ; relies on revision number Initial Comment: If ant is run on code from .tar.gz distribution, the version-info task does not do what is supposed to do (generate a Info.java) because the revision number is empty. Additionally, the version-info task does not fail, it continues on its way, so the notification that something is wrong is not known until the build fails due to a missing Info.java file. Additionally, the VerGen class gives us the following error message: All version-related parameters must be invalid integers! I think that valid is the word you want here. :) ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 15:49 Message: Logged In: YES user_id=12853 Originator: NO I noticed the same issue when using GIT to manage local repositories of ZooKeeper. The build fails because it assumes that the code is contained within a svn repository. I will look into resolving this (specifically version gen being tied to svn, not the other distro issues). ---------------------------------------------------------------------- Comment By: Andrew Kornev (akornev) Date: 2008-05-05 12:38 Message: Logged In: YES user_id=1926652 Originator: NO Erik, thanks for catching that. I think we released the source tar a bit prematurely. While we're working on the fix, you're advised to either use the binary server tar or build from the SVN repository. Thanks! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958183&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 22:46:47
|
Bugs item #1956937, was opened at 2008-05-03 14:47 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1956937&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: fpj (fpj) >Assigned to: fpj (fpj) Summary: Null WatcherEvent/Watcher Initial Comment: Got the following error message: ERROR - [EventThread:ClientCnxn$1@245] - from EventThread java.lang.NullPointerException at com.yahoo.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:264) Finished starting ZK: com.yahoo.zookeeper.ZooKeeper@17ee8b8 ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 15:46 Message: Logged In: YES user_id=12853 Originator: NO Flavio can you resolve this issue based on Ben's feedback? Make the change, verify it and submit a patch? ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-05 08:01 Message: Logged In: YES user_id=154690 Originator: NO It looks like there is a race condition in ZooKeeper.java: the watcher should be set before the ClientCnxn is created. Watcher should also be declared volatile. ---------------------------------------------------------------------- Comment By: fpj (fpj) Date: 2008-05-03 16:02 Message: Logged In: YES user_id=1926444 Originator: YES I register a large number of watches in a row, and most of them worked. In fact, out of several runs, I got this problem once, which makes me think that the bug not deterministic. ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-03 15:10 Message: Logged In: YES user_id=12853 Originator: NO My source tree line 264 is : zooKeeper.watcher.process((WatcherEvent) event); which would typically indicate that watcher is null, not the event. Perhaps you registered a null watcher? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1956937&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 22:42:46
|
Bugs item #1958195, was opened at 2008-05-05 12:37 Message generated for change (Comment added) made by phunt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) Assigned to: Nobody/Anonymous (nobody) Summary: log4j is not present in zookeeper.jar Initial Comment: The attached patch includes log4j classes in the zookeeper.jar file. ---------------------------------------------------------------------- >Comment By: Patrick Hunt (phunt) Date: 2008-05-05 15:42 Message: Logged In: YES user_id=12853 Originator: NO Thanks egh -- I further updated the page to reference the zookeeper logging page. The packaging issues are being worked on and should be addressed shortly. Regards. ---------------------------------------------------------------------- Comment By: Erik Hetzner (egh) Date: 2008-05-05 15:15 Message: Logged In: YES user_id=67250 Originator: YES Ok, I modified the wiki tutorial to remove information stating that the .jar file can be used as a standalone jar. You might also want to remove the .jar file distributed on sf.net, because it is impossible to run this file using -jar. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-05 14:20 Message: Logged In: YES user_id=154690 Originator: NO It is intentional. The fat jar proponent was out voted. We will be doing a new release shortly that distributes the java component as a tar.gz with scripts to start things up. ---------------------------------------------------------------------- Comment By: Erik Hetzner (egh) Date: 2008-05-05 12:44 Message: Logged In: YES user_id=67250 Originator: YES Perhaps this is intentional? It means that the binary server jar distributed via sf.net is not stand alone, however. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 22:15:26
|
Bugs item #1958195, was opened at 2008-05-05 19:37 Message generated for change (Comment added) made by egh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) Assigned to: Nobody/Anonymous (nobody) Summary: log4j is not present in zookeeper.jar Initial Comment: The attached patch includes log4j classes in the zookeeper.jar file. ---------------------------------------------------------------------- >Comment By: Erik Hetzner (egh) Date: 2008-05-05 22:15 Message: Logged In: YES user_id=67250 Originator: YES Ok, I modified the wiki tutorial to remove information stating that the .jar file can be used as a standalone jar. You might also want to remove the .jar file distributed on sf.net, because it is impossible to run this file using -jar. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-05 21:20 Message: Logged In: YES user_id=154690 Originator: NO It is intentional. The fat jar proponent was out voted. We will be doing a new release shortly that distributes the java component as a tar.gz with scripts to start things up. ---------------------------------------------------------------------- Comment By: Erik Hetzner (egh) Date: 2008-05-05 19:44 Message: Logged In: YES user_id=67250 Originator: YES Perhaps this is intentional? It means that the binary server jar distributed via sf.net is not stand alone, however. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 21:20:25
|
Bugs item #1958195, was opened at 2008-05-05 12:37 Message generated for change (Comment added) made by breed You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) Assigned to: Nobody/Anonymous (nobody) Summary: log4j is not present in zookeeper.jar Initial Comment: The attached patch includes log4j classes in the zookeeper.jar file. ---------------------------------------------------------------------- >Comment By: Benjamin Reed (breed) Date: 2008-05-05 14:20 Message: Logged In: YES user_id=154690 Originator: NO It is intentional. The fat jar proponent was out voted. We will be doing a new release shortly that distributes the java component as a tar.gz with scripts to start things up. ---------------------------------------------------------------------- Comment By: Erik Hetzner (egh) Date: 2008-05-05 12:44 Message: Logged In: YES user_id=67250 Originator: YES Perhaps this is intentional? It means that the binary server jar distributed via sf.net is not stand alone, however. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 21:15:59
|
Patches item #1958274, was opened at 2008-05-05 23:16 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1958274&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: server Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: fpj (fpj) Assigned to: Nobody/Anonymous (nobody) Summary: Removed unused variables from FastLeaderElection Initial Comment: Removed unused variables from FastLeaderElection. -Flavio ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1958274&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 21:12:04
|
Patches item #1951806, was opened at 2008-04-25 10:10 Message generated for change (Comment added) made by breed You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1951806&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ted Dunning (tedunning) Assigned to: Nobody/Anonymous (nobody) Summary: Sample startup script Initial Comment: This may be useful as a temporary script. Eventually there are several things that should be improved: a) the log rotation hack should go away when real logging get implemented b) the kill hack should go away when there is a good way to kill the process. In the meantime, this may be handy to people at least as a starting point. ---------------------------------------------------------------------- >Comment By: Benjamin Reed (breed) Date: 2008-05-05 14:12 Message: Logged In: YES user_id=154690 Originator: NO Okay, I've enhanced your patch a lot Ted. It assumes an installation directory structure of bin, lib, and conf as siblings. It finds the directory based on the realpath of the script being run. (This is how things like firefox and java are setup on Linux usually.) zkServer.sh is designed to be run from init.d zkCleanup.sh is designed to run from cron zkCli.sh is designed to run from a shell. File Added: scripts.patch ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-05-01 15:58 Message: Logged In: YES user_id=972206 Originator: YES Ben, Your comments are good, but this is a place-holder. I would hope that you guys would have something much better soon. a) regarding logging, the logging system should do log rotation and cleanup. Until logging is available in a released version (and I build a log configuration file), I will just do the rotation in this script. It is a placeholder and work-around, after all. b) regarding dirname, please change anything like that you like. It is a good idea. c) regarding zoo.cfg in /etc, I can't comment if that really is a good place or not. If you would like to standardize on that, fine. Perhaps, I should put in a bit of baby logic to look first in /etc/zoo.cfg and then in $ZOO/zoo.cfg. d) regarding zoo.cfg instead of ZOO/zoo.cfg, that is just an error. Thanks for catching it. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 15:00 Message: Logged In: YES user_id=154690 Originator: NO Thanx Ted. I think ZOO should be set using dirname $0 Log cleanup shouldn't really be done in the startup scripts right? Finally, I think we should get the config from /etc/zookeeper/zoo.cfg right? In your script you use $ZOO/zoo.cfg and zoo.cfg, but both seem wrong (with the latter more wrong :) ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 14:20 Message: Logged In: YES user_id=154690 Originator: NO Deleted old version so it was clear what we were reviewing. ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-30 10:47 Message: Logged In: YES user_id=972206 Originator: YES Here is an updated script that uses the kill command. I am quite dubious of the wisdom of allowing arbitrary processes anywhere on the net to kill a zookeeper. It definitely means that zookeepers cannot be exposed at all to anything except a very friendly environment. File Added: zookeeper.sh ---------------------------------------------------------------------- Comment By: Ted Dunning (tedunning) Date: 2008-04-29 16:42 Message: Logged In: YES user_id=972206 Originator: YES The kill hack is interesting. Good thing to know about. Kind of a dangerous feature, though. It also requires that I know something about the config or write something clever in the script that turns the config file into the telnet or nc command. The logs I am talking about are the accumulation of what currently comes out of standard output, not the transactional logs. I think that there is an enhancement coming that will use log4J. That would be vastly better than my hack of putting standard out to a file. ---------------------------------------------------------------------- Comment By: Andrew Kornev (akornev) Date: 2008-04-29 15:34 Message: Logged In: YES user_id=1926652 Originator: NO A better way to kill a server to send a kill command to the server's client port (the clientPort parameter in zoo.cfg), for example: echo kill|nc localhost 1234 ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-04-25 11:52 Message: Logged In: YES user_id=12853 Originator: NO Ted, be aware that there is also the following to be managed. The "log files" reference are transacitonal log files - not logging log files. "The ZooKeeper server creates snapshot and log files, but never deletes them. The retention policy of the data and log files is implemented outside of the ZooKeeper server. The server itself only needs the latest complete fuzzy snapshot and the log files from the start of that snapshot. The PurgeTxnLog utility implements a simple retention policy that administrators can use." http://zookeeper.wiki.sourceforge.net/ZooKeeperDataFormat ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1951806&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 19:44:55
|
Bugs item #1958195, was opened at 2008-05-05 19:37 Message generated for change (Comment added) made by egh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) Assigned to: Nobody/Anonymous (nobody) Summary: log4j is not present in zookeeper.jar Initial Comment: The attached patch includes log4j classes in the zookeeper.jar file. ---------------------------------------------------------------------- >Comment By: Erik Hetzner (egh) Date: 2008-05-05 19:44 Message: Logged In: YES user_id=67250 Originator: YES Perhaps this is intentional? It means that the binary server jar distributed via sf.net is not stand alone, however. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 19:38:10
|
Bugs item #1958183, was opened at 2008-05-05 12:22 Message generated for change (Comment added) made by akornev You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958183&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: server Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) Assigned to: Nobody/Anonymous (nobody) Summary: tar.gz does not build ; relies on revision number Initial Comment: If ant is run on code from .tar.gz distribution, the version-info task does not do what is supposed to do (generate a Info.java) because the revision number is empty. Additionally, the version-info task does not fail, it continues on its way, so the notification that something is wrong is not known until the build fails due to a missing Info.java file. Additionally, the VerGen class gives us the following error message: All version-related parameters must be invalid integers! I think that valid is the word you want here. :) ---------------------------------------------------------------------- >Comment By: Andrew Kornev (akornev) Date: 2008-05-05 12:38 Message: Logged In: YES user_id=1926652 Originator: NO Erik, thanks for catching that. I think we released the source tar a bit prematurely. While we're working on the fix, you're advised to either use the binary server tar or build from the SVN repository. Thanks! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958183&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 19:37:32
|
Bugs item #1958195, was opened at 2008-05-05 19:37 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) Assigned to: Nobody/Anonymous (nobody) Summary: log4j is not present in zookeeper.jar Initial Comment: The attached patch includes log4j classes in the zookeeper.jar file. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958195&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 19:22:37
|
Bugs item #1958183, was opened at 2008-05-05 19:22 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958183&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: server Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Erik Hetzner (egh) Assigned to: Nobody/Anonymous (nobody) Summary: tar.gz does not build ; relies on revision number Initial Comment: If ant is run on code from .tar.gz distribution, the version-info task does not do what is supposed to do (generate a Info.java) because the revision number is empty. Additionally, the version-info task does not fail, it continues on its way, so the notification that something is wrong is not known until the build fails due to a missing Info.java file. Additionally, the VerGen class gives us the following error message: All version-related parameters must be invalid integers! I think that valid is the word you want here. :) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1958183&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-05 15:00:58
|
Bugs item #1956937, was opened at 2008-05-03 14:47 Message generated for change (Comment added) made by breed You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1956937&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: fpj (fpj) Assigned to: Nobody/Anonymous (nobody) Summary: Null WatcherEvent/Watcher Initial Comment: Got the following error message: ERROR - [EventThread:ClientCnxn$1@245] - from EventThread java.lang.NullPointerException at com.yahoo.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:264) Finished starting ZK: com.yahoo.zookeeper.ZooKeeper@17ee8b8 ---------------------------------------------------------------------- >Comment By: Benjamin Reed (breed) Date: 2008-05-05 08:01 Message: Logged In: YES user_id=154690 Originator: NO It looks like there is a race condition in ZooKeeper.java: the watcher should be set before the ClientCnxn is created. Watcher should also be declared volatile. ---------------------------------------------------------------------- Comment By: fpj (fpj) Date: 2008-05-03 16:02 Message: Logged In: YES user_id=1926444 Originator: YES I register a large number of watches in a row, and most of them worked. In fact, out of several runs, I got this problem once, which makes me think that the bug not deterministic. ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-03 15:10 Message: Logged In: YES user_id=12853 Originator: NO My source tree line 264 is : zooKeeper.watcher.process((WatcherEvent) event); which would typically indicate that watcher is null, not the event. Perhaps you registered a null watcher? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008544&aid=1956937&group_id=209147 |
|
From: SourceForge.net <no...@so...> - 2008-05-03 23:12:50
|
Patches item #1956499, was opened at 2008-05-02 16:58 Message generated for change (Comment added) made by breed You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1956499&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andrew Kornev (akornev) Assigned to: Nobody/Anonymous (nobody) Summary: the dist build target Initial Comment: The patch adds a new build target to the ant build file -- "dist". The target builds all of the zookeeper distribution tar files in one shot: java source, java binary and c client source. Once the build has finished, the tar files are located in ${basedir}/distribution and ready to be uploaded to the distribution server. ---------------------------------------------------------------------- >Comment By: Benjamin Reed (breed) Date: 2008-05-03 16:12 Message: Logged In: YES user_id=154690 Originator: NO Looks good Andrew. I don't think we should change to Java 1.6 though until we have to. The poor Mac users have to suffer with an Java 1.5. (Although the Mac koolaid seems to allow them to forget their suffering :) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1956499&group_id=209147 |
