[Zookeeper-developer] [ zookeeper-Patches-1944441 ] fix 1941109 -- arraylist -> list<T> in interfaces

[SourceForge.net <no...@so...>]

Patches item #1944441, was opened at 2008-04-16 23:01
Message generated for change (Comment added) made by mahadevkonar
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1944441&group_id=209147

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: 3.0.0
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Patrick Hunt (phunt)
Assigned to: Mahadev Konar (mahadevkonar)
Summary: fix 1941109 -- arraylist -> list<T> in interfaces

Initial Comment:
fix for 1941109 -- move to more abstract interfaces.

arraylist -> list<t>

This may require changes to user code.

Documentation will need to be updated.


----------------------------------------------------------------------

>Comment By: Mahadev Konar (mahadevkonar)
Date: 2008-05-29 20:13

Message:
Logged In: YES 
user_id=1926680
Originator: NO

I agree that the datatree should not be public and be used by clients.
Closing the bug for now. 

----------------------------------------------------------------------

Comment By: Benjamin Reed (breed)
Date: 2008-05-20 01:55

Message:
Logged In: YES 
user_id=154690
Originator: NO

DataTree is public with respect to Java, but it is not public with respect
to the public API of ZooKeeper. No one should be using DataTree directly.
Perhaps in the future there may be people that access it, but I don't think
it is something we should be worried about now.

----------------------------------------------------------------------

Comment By: Andrew Kornev (akornev)
Date: 2008-05-20 00:06

Message:
Logged In: YES 
user_id=1926652
Originator: NO

Yes, I mean DataTree.getChildren(). Although, I'm not sure what you meant
by "the method is private to zk implementation" (it seems quite public to
me), I just thought that if we have changed getACL()'s return type from
ArrayList<> to List<> then, for consistency, we should change
getChildren()'s, too. Is it possible to fix this as part of this patch?

----------------------------------------------------------------------

Comment By: Patrick Hunt (phunt)
Date: 2008-05-19 23:07

Message:
Logged In: YES 
user_id=12853
Originator: YES

You mean DataTree.java right?

I think it's ok in this case. The method is private to zk implementation
-- I updated the public interfaces not necessarily the private ones. Also
you can cast the return value to a List easily (not something you can
easily do when passing List as argument of type ArrayList). Please enter a
bug if you think we should fix.

Thanks.


----------------------------------------------------------------------

Comment By: Andrew Kornev (akornev)
Date: 2008-05-19 22:28

Message:
Logged In: YES 
user_id=1926652
Originator: NO

Was it your intention to have getChildren returning ArrayList<> and not
List<>?

public ArrayList<String> getChildren(String path, Stat stat, Watcher
watcher) throws KeeperException.NoNodeException

----------------------------------------------------------------------

Comment By: Mahadev Konar (mahadevkonar)
Date: 2008-05-19 19:30

Message:
Logged In: YES 
user_id=1926680
Originator: NO

committed revision 168. Thanks Pat.


----------------------------------------------------------------------

Comment By: Patrick Hunt (phunt)
Date: 2008-05-16 21:41

Message:
Logged In: YES 
user_id=12853
Originator: YES

Here's an updated patch.

File Added: parameterizedlist2.patch

----------------------------------------------------------------------

Comment By: Mahadev Konar (mahadevkonar)
Date: 2008-05-15 21:33

Message:
Logged In: YES 
user_id=1926680
Originator: NO

gievn the updates to zookeeper this patch does not apply cleanly. Pat can
you upload a new patch for this that applied to the trunk?

----------------------------------------------------------------------

Comment By: Benjamin Reed (breed)
Date: 2008-05-01 21:30

Message:
Logged In: YES 
user_id=154690
Originator: NO

We need to hold this until we start 3.0.0 because of the API breakage.

----------------------------------------------------------------------

Comment By: Benjamin Reed (breed)
Date: 2008-05-01 21:30

Message:
Logged In: YES 
user_id=154690
Originator: NO

+1 patch looks good

----------------------------------------------------------------------

Comment By: Benjamin Reed (breed)
Date: 2008-04-17 16:56

Message:
Logged In: YES 
user_id=154690
Originator: NO

Can we merge this with 1944401. The purposes overlap.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1944441&group_id=209147