Menu
▾
▴
[Zookeeper-developer] [ zookeeper-Patches-1944401 ] make callbacks more abstract
|
From: SourceForge.net <no...@so...> - 2008-05-19 23:40:51
|
Patches item #1944401, was opened at 2008-04-16 21:43 Message generated for change (Comment added) made by mahadevkonar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1944401&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: 3.0.0 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Patrick Hunt (phunt) Assigned to: Mahadev Konar (mahadevkonar) Summary: make callbacks more abstract Initial Comment: Replace arraylist with list in acl and children callbacks. Will this effect ppl upgrading? Probably should mitigate by release noting. ---------------------------------------------------------------------- >Comment By: Mahadev Konar (mahadevkonar) Date: 2008-05-19 23:40 Message: Logged In: YES user_id=1926680 Originator: NO this has already been fixed as part of the https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1944441&group_id=209147 Closing this bug. ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-19 21:33 Message: Logged In: YES user_id=12853 Originator: YES different patch, similar underlying issue. This patch should also be applied. It changes the callbacks intf rather than the zk client interface. ---------------------------------------------------------------------- Comment By: Mahadev Konar (mahadevkonar) Date: 2008-05-19 19:34 Message: Logged In: YES user_id=1926680 Originator: NO Pat, is this part of the ArrayList -> List change filed via https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1944441&group_id=209147 ? ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 21:36 Message: Logged In: YES user_id=154690 Originator: NO We should hold until 3.0.0 because of the API change. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 21:36 Message: Logged In: YES user_id=154690 Originator: NO +1 patch looks good ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-04-16 22:01 Message: Logged In: YES user_id=154690 Originator: NO Yes, it will effect existing code. I think we should hold this patch until we do the next release. Then I'd like to put in this patch, fix the bug that changes the watch types and states to enums instead of int, and put in the safety checks in the feature requests. I'm wondering if this patch should create an async or callback package and make the interfaces top level interfaces in that package rather than using the AsyncCallback container. I don't mind how it is now, but Ted commented that some IDEs have problems with nested classes. On the other hand, it will break the implementors of this interface even more. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1944401&group_id=209147 |
