Menu
▾
▴
[Zookeeper-developer] [ zookeeper-Patches-1955134 ] Cleanup logging priorities
|
From: SourceForge.net <no...@so...> - 2008-05-10 01:15:15
|
Patches item #1955134, was opened at 2008-04-30 23:35 Message generated for change (Settings changed) made by fpj You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1955134&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: None Priority: 7 Private: No Submitted By: Patrick Hunt (phunt) Assigned to: fpj (fpj) Summary: Cleanup logging priorities Initial Comment: This patch cleans up logging priorities (error/warn/info) Previous to log4j all logging was either error or warn (there was no info). I have reviewed all logging looking for: 1) errors that should be warnings I consider a log to be a warning if the code is not exiting, rethrowing an exception or otherwise attempts to recover from the issue. This is not obvious in all cases but generally true. 2) warnings that should be info there was no "info" equivalent in the pre-log4j code. most cases coders used warning level instead. I converted these calls to info where appropriate. 3) I also cleaned up some issues - like missing message in a log call such as LOG.error/warn("MISSINGMSG", e) - ie handling exception. 4) I added a few INFO level messages where appropriate. I suggest that you look for missing messages (esp info) when reviewing the code (submit a patch). ---------------------------------------------------------------------- Comment By: fpj (fpj) Date: 2008-05-10 02:53 Message: Logged In: YES user_id=1926444 Originator: NO Looks good, proceeding to commit. ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 19:44 Message: Logged In: YES user_id=12853 Originator: YES The assignee is responsible for closing (committing) this patch (see ZooKeeperPatches on wiki) -- this includes getting additional review if necessary. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 23:35 Message: Logged In: YES user_id=154690 Originator: NO +1 make it happen ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-01 23:34 Message: Logged In: YES user_id=154690 Originator: NO Fixed the patch to make errors that cause System.exit fatal File Added: log4jcleanup(2).patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1955134&group_id=209147 |
