[Zookeeper-developer] [ zookeeper-Patches-1956480 ] cleanup trace logging

[SourceForge.net <no...@so...>]

Patches item #1956480, was opened at 2008-05-02 15:48
Message generated for change (Comment added) made by phunt
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1956480&group_id=209147

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Patrick Hunt (phunt)
Assigned to: Andrew Kornev (akornev)
Summary: cleanup trace logging

Initial Comment:
Cleanup of trace logging.

Renamed ZooLog to ZooTrace. Major cleanup of tracing.

When this is merged please review the trace messages - it looks like a number of them are really debug/info level messages - they should be updated appropriately.

This should be the last major change for log4j integration - other than adding more info/debug/trace messages as appropriate.


----------------------------------------------------------------------

>Comment By: Patrick Hunt (phunt)
Date: 2008-05-08 14:34

Message:
Logged In: YES 
user_id=12853
Originator: YES

File Added: tracecleanup3.patch.gz

----------------------------------------------------------------------

Comment By: Patrick Hunt (phunt)
Date: 2008-05-07 15:09

Message:
Logged In: YES 
user_id=12853
Originator: YES

The first issue you mention is a common pattern for logging code - the
"istraceenabled" eliminates the string concatenation expense when tracing
is not turned on (optimization).
(should not be changed)

----------------------------------------------------------------------

Comment By: Andrew Kornev (akornev)
Date: 2008-05-07 14:50

Message:
Logged In: YES 
user_id=1926652
Originator: NO

Other than a few things mentioned below, the patch looks good.

ClientCnxn.java: This check to see if trace is enabled seems to be
redundant as logTraceMessage() performs the same check:

        long traceMask = ZooTrace.SESSION_TRACE_MASK;
        if (ZooTrace.isTraceEnabled(LOG, traceMask)) {
            ZooTrace.logTraceMessage(LOG, traceMask,
                    "Close ClientCnxn for session: " + sessionId + "!");
        }

util/Profiler.java: Unused TraceLog import, LOG severity should be warn
not error

Unused TraceLog import:

AuthFastLeaderElection.java
FastLeaderElection.java
FollowerZooKeeperServer.java
Leader.java
LeaderElection.java
QuorumCnxManager.java
QuorumPeerConfig.java
SendAckRequestProcessor.java


----------------------------------------------------------------------

Comment By: Patrick Hunt (phunt)
Date: 2008-05-06 10:43

Message:
Logged In: YES 
user_id=12853
Originator: YES

The assignee is responsible for closing (committing) this patch (see
ZooKeeperPatches on wiki) -- this includes getting additional review if
necessary.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1956480&group_id=209147