Menu
▾
▴
[Zookeeper-developer] [ zookeeper-Patches-1958274 ] Removed unused variables from FastLeaderElection
|
From: SourceForge.net <no...@so...> - 2008-05-08 21:06:16
|
Patches item #1958274, was opened at 2008-05-05 21:16 Message generated for change (Comment added) made by mahadevkonar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1958274&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: server Group: None Status: Closed Resolution: Fixed Priority: 7 Private: No Submitted By: fpj (fpj) Assigned to: Mahadev Konar (mahadevkonar) Summary: Removed unused variables from FastLeaderElection Initial Comment: Removed unused variables from FastLeaderElection. -Flavio ---------------------------------------------------------------------- >Comment By: Mahadev Konar (mahadevkonar) Date: 2008-05-08 21:06 Message: Logged In: YES user_id=1926680 Originator: NO yes . thats how I applied the patch. Its generally a good practice to upload a patch from the trunk so that the reviewer and the committer can just do patch -p0 and be done with it.. ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-08 20:22 Message: Logged In: YES user_id=12853 Originator: NO Mahadev re point 1 - just use the "patch -p# < patchfile" option, it will correctly strip the prefix (you need to tell it what depth via the #, -p3 strips 3 from the prefix dirhier). ---------------------------------------------------------------------- Comment By: Mahadev Konar (mahadevkonar) Date: 2008-05-08 18:53 Message: Logged In: YES user_id=1926680 Originator: NO ok ... i updated the patch myself ... committed to revision 154 but two points for future flavio :)-- 1) the diff should be generated from the zookeeper directory. this patch had diff from C:/ something 2) make sure that the patch does not have any windows characters. also another bug would be to open some indentation issues in the original code in fast le (not in the patch). ---------------------------------------------------------------------- Comment By: Mahadev Konar (mahadevkonar) Date: 2008-05-08 18:42 Message: Logged In: YES user_id=1926680 Originator: NO +1 looks good but the only problem is with ^M charaters present in the patch. Can you get rid of this? it usually happens on windows files that they have ^M charaters at the end of line... ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-07 05:44 Message: Logged In: YES user_id=12853 Originator: NO Flavio please delete the old patch(es). ---------------------------------------------------------------------- Comment By: fpj (fpj) Date: 2008-05-07 05:17 Message: Logged In: YES user_id=1926444 Originator: YES File Added: patch-fle.diff ---------------------------------------------------------------------- Comment By: fpj (fpj) Date: 2008-05-07 05:05 Message: Logged In: YES user_id=1926444 Originator: YES No, they are patches for different implementations. I separated them to make it easier to review the patches. -Flavio ---------------------------------------------------------------------- Comment By: Mahadev Konar (mahadevkonar) Date: 2008-05-07 02:54 Message: Logged In: YES user_id=1926680 Originator: NO is this related to https://sourceforge.net/tracker/index.php?func=detail&aid=1956801&group_id=209147&atid=1008546 ? from the description it looks like they are the same... ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 18:34 Message: Logged In: YES user_id=12853 Originator: NO There is an issue with this patch: 1) line 248 has "rand" variable which the patch removes initialization, but not the field also: 2) cleanup imports (remove random and zoolog) 3) there are more unused vars which could be removed, lines; 152, 250, 269 Btw - if you are using eclipse you can get findbugs at: http://findbugs.sourceforge.net/manual/eclipse.html ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 17:40 Message: Logged In: YES user_id=12853 Originator: NO The assignee is responsible for closing (committing) this patch (see ZooKeeperPatches on wiki) -- this includes getting additional review if necessary. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1958274&group_id=209147 |
