Menu
▾
▴
[Zookeeper-developer] [ zookeeper-Patches-1956499 ] the dist build target
|
From: SourceForge.net <no...@so...> - 2008-05-07 19:20:59
|
Patches item #1956499, was opened at 2008-05-02 16:58 Message generated for change (Comment added) made by akornev You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1956499&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 7 Private: No Submitted By: Andrew Kornev (akornev) Assigned to: Benjamin Reed (breed) Summary: the dist build target Initial Comment: The patch adds a new build target to the ant build file -- "dist". The target builds all of the zookeeper distribution tar files in one shot: java source, java binary and c client source. Once the build has finished, the tar files are located in ${basedir}/distribution and ready to be uploaded to the distribution server. ---------------------------------------------------------------------- >Comment By: Andrew Kornev (akornev) Date: 2008-05-07 12:20 Message: Logged In: YES user_id=1926652 Originator: YES Committed at revision 153 ---------------------------------------------------------------------- Comment By: Andrew Kornev (akornev) Date: 2008-05-06 16:56 Message: Logged In: YES user_id=1926652 Originator: YES This patch is the same as the previous one except, in anticipation of the [1951806] patch going in, the java-src and java-bin packages include the bin/* directory. File Added: build-3.patch ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-06 16:37 Message: Logged In: YES user_id=154690 Originator: NO +1 Looks good. It worked for me. I think we need to rev it before committing. [ 1951806 ] Sample startup script Needs to go in first and the bin directory should be included in the java-bin tar.gz ---------------------------------------------------------------------- Comment By: Andrew Kornev (akornev) Date: 2008-05-06 16:06 Message: Logged In: YES user_id=1926652 Originator: YES 1) the target JDK version is a property now. By default, it's set to the version of the compiler. It can be overwritten from the command line: "-Dtarget.jdk=1.x". The new JMX feature is only available for JDK 1.6. 2) fixes bug [1958183] where the build fails because of an invalid SVN revision number. The "dist" target generates "revision.properties" file that is then included in the java source tar. The presence of the properties file supresses the SVN revision check during subsequent builds from the source tar. 3) fixed an incomplete error message issued by the "dist" target build if the C client Makefile is not present. 4) the "dist" target now produces a unified zookeeper-x.y.x.tar.gz file in the project basedir as well as separate java and C package files under the distribution/ directory. 5) updated the current release number to 2.2.0 File Added: build-2.patch ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 12:08 Message: Logged In: YES user_id=12853 Originator: NO I'm unable to build dist on my linux machine: BUILD FAILED build.xml:227: The following error occurred while executing this line: build.xml:200: Please run 'autoreconf -i' in c/ irectory to generate a Makefile. I've run "autoreconf -i" a number of times here is the output: :~/workspaces/zookeeper/c$ autoreconf -i libtoolize: `config.guess' exists: use `--force' to overwrite libtoolize: `config.sub' exists: use `--force' to overwrite libtoolize: `ltmain.sh' exists: use `--force' to overwrite Makefile.am:60: wildcard tests/*.cc: non-POSIX variable name Makefile.am:60: (probably a GNU make extension) Makefile.am:60: wildcard tests/*.h: non-POSIX variable name Makefile.am:60: (probably a GNU make extension) Makefile.am:67: shell cat tests/wrappers.opt: non-POSIX variable name Makefile.am:67: (probably a GNU make extension) Makefile.am:80: shell cat tests/wrappers-mt.opt: non-POSIX variable name Makefile.am:80: (probably a GNU make extension) ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 11:54 Message: Logged In: YES user_id=12853 Originator: NO Please remove requirement for java 1.6 (back to 1.5) for the time being. ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 10:42 Message: Logged In: YES user_id=12853 Originator: NO The assignee is responsible for closing (committing) this patch (see ZooKeeperPatches on wiki) -- this includes getting additional review if necessary. ---------------------------------------------------------------------- Comment By: Benjamin Reed (breed) Date: 2008-05-03 16:12 Message: Logged In: YES user_id=154690 Originator: NO Looks good Andrew. I don't think we should change to Java 1.6 though until we have to. The poor Mac users have to suffer with an Java 1.5. (Although the Mac koolaid seems to allow them to forget their suffering :) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1956499&group_id=209147 |
